[jira] Commented: (HADOOP-3623) LeaseManager needs refactoring.

["Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631224#action_12631224 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3623:
------------------------------------------------

{noformat}
     [exec] -1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
{noformat}

No new test included since it is a code refactoring.

> LeaseManager needs refactoring.
> -------------------------------
>
>                 Key: HADOOP-3623
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3623
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.0
>
>         Attachments: 3623_20080915.patch
>
>
> LeaseManager is a name-node class, which contains (after HADOOP-3310) static members and methods serving data-node code.
> I think we should keep the code related to different components of hdfs separatly, especially in view of the upcoming changes in hdfs packaging HADOOP-2884.
> The separation may be achieved by introducing a new class DatanodeLeaseManager and then moving all related methods into the new class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.