You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/06/04 16:48:00 UTC

[jira] [Work logged] (GOBBLIN-794) JsonIntermediateToAvroConverter cannot process highly nested array/object schema

     [ https://issues.apache.org/jira/browse/GOBBLIN-794?focusedWorklogId=253844&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253844 ]

ASF GitHub Bot logged work on GOBBLIN-794:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jun/19 16:47
            Start Date: 04/Jun/19 16:47
    Worklog Time Spent: 10m 
      Work Description: chris9692 commented on pull request #2661: [GOBBLIN-794] JsonIntermediateToAvroConverter cannot process array-object-array-object nested pattern
URL: https://github.com/apache/incubator-gobblin/pull/2661
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I have a use case pending this fix.
   
   ### JIRA
   - [ ] My PR addresses the following:
       - https://issues.apache.org/jira/browse/GOBBLIN-794
   
   ### Description
   - [ ] changes are adding namespace parameter to ArrayConverter of the JsonIntermediateToAvroConverter, and there is a test case to verify.
   
   ### Tests
   - [ ] My PR adds the following unit tests:   testConverterWithNestJson
   - [ ] Unit test results:
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest. STARTED
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest. PASSED
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest. STARTED
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest. PASSED
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest. STARTED
   Gradle suite > Gradle test > org.apache.gobblin.converter.json.JsonStringToJsonIntermediateConverterTest. PASSED
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 253844)
            Time Spent: 10m
    Remaining Estimate: 3h 50m  (was: 4h)

> JsonIntermediateToAvroConverter cannot process highly nested array/object schema
> --------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-794
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-794
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-core
>    Affects Versions: 0.15.0
>            Reporter: Chris Li
>            Assignee: Abhishek Tiwari
>            Priority: Major
>   Original Estimate: 4h
>          Time Spent: 10m
>  Remaining Estimate: 3h 50m
>
> in sample schema with array in object and object in array, namespace got lost in the middle when calling ArrayConverter, therefore the last level of object processing fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)