You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/03 23:33:45 UTC
[GitHub] [spark] rdblue commented on issue #25747: [SPARK-29039][SQL]
centralize the catalog and table lookup logic
rdblue commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic
URL: https://github.com/apache/spark/pull/25747#issuecomment-538168488
@cloud-fan, looks good. The only thing other than nits is that I think we should probably rename `UnresolvedV2Table` to `UnresolvedV2Relation` because it could resolve to a view and is not necessarily a table. Otherwise, +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org