You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/25 15:47:33 UTC

[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #402: Network Monitor: Runtime selection of DHCP/Static IP with fall back set by the board, and a polled mode for HW lacking a PHY interrupt

patacongo commented on pull request #402:
URL: https://github.com/apache/incubator-nuttx-apps/pull/402#issuecomment-699005302


   > I've looked at this twice now and nothing stands out. I'll let the others comments get responded to before approving.
   
   The use of boardctl() in this way is unacceptable.  I discuss in the matching PR apache/incubator-nuttx#1886


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org