You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2013/04/03 20:59:52 UTC

Review Request: QMF console drops V2 object updates and heartbeat indications

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10270/
-----------------------------------------------------------

Review request for qpid, Ted Ross and Fraser Adams.


Description
-------

The QMF V2 path for object updates and heartbeat notifications is broken.  An application that has registered a Console for callbacks will not receive these indications if the broker is configured to only use QMFv2 (default is both v2 and v1).


This addresses bug qpid-4689.
    https://issues.apache.org/jira/browse/qpid-4689


Diffs
-----

  /trunk/qpid/cpp/src/tests/CMakeLists.txt 1463626 
  /trunk/qpid/cpp/src/tests/qpidd_qmfv2_tests.py PRE-CREATION 
  /trunk/qpid/extras/qmf/src/py/qmf/console.py 1463626 

Diff: https://reviews.apache.org/r/10270/diff/


Testing
-------

Out existing test suite usually runs the brokers with both v1 and v2 turned on (the default).  I've added a new test set that runs the console against a broker that has v1 turned off - QMF v2 only.  This would've caught the bug.


Thanks,

Kenneth Giusti