You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by "lprimak (via GitHub)" <gi...@apache.org> on 2026/06/22 15:01:55 UTC
[PR] [backport: 2.x] Discard Jenkins build workspace after 30 days (#2806) [shiro]
lprimak opened a new pull request, #2808:
URL: https://github.com/apache/shiro/pull/2808
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [backport: 2.x] Discard Jenkins build workspace after 30 days (#2806) [shiro]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2808:
URL: https://github.com/apache/shiro/pull/2808#discussion_r3453273164
##########
.jenkins.groovy:
##########
@@ -29,7 +29,7 @@ pipeline {
options {
// When we have test-fails e.g. we don't need to run the remaining steps
skipStagesAfterUnstable()
- buildDiscarder(logRotator(numToKeepStr: '5', artifactNumToKeepStr: '5'))
+ buildDiscarder(logRotator(numToKeepStr: '5', artifactNumToKeepStr: '5', daysToKeepStr: '30'))
Review Comment:
`buildDiscarder(logRotator(...))` only controls retention of *build records/artifacts* in Jenkins; it does not clean up agent workspaces (and this pipeline uses a fixed `customWorkspace`, which will persist on disk). If the intent of this PR is truly to discard/cleanup workspaces after 30 days, this change won’t achieve that—please either clarify/update the PR title/description, or add an explicit workspace cleanup strategy (e.g., workspace cleanup in `post`/Jenkins job configuration) appropriate for your Jenkins setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [backport: 2.x] Discard Jenkins build workspace after 30 days (#2806) [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak closed pull request #2808: [backport: 2.x] Discard Jenkins build workspace after 30 days (#2806)
URL: https://github.com/apache/shiro/pull/2808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org