You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Filipe Manana (JIRA)" <ji...@apache.org> on 2011/01/02 14:22:45 UTC
[jira] Commented: (COUCHDB-1004) list_to_existing_atom is too
restrictive as used by couch_rep
[ https://issues.apache.org/jira/browse/COUCHDB-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976513#action_12976513 ]
Filipe Manana commented on COUCHDB-1004:
----------------------------------------
I agree. In some cases it's not really an issue.
I would vote to replace our to_existing_atom/1 function in couch_util with something like:
%% @spec to_atom(term(), allow_new())
%% @type allow_new() = boolean()
to_atom(V, false) ->
list_to_existing_atom(to_list(V));
to_atom(V, true) ->
V1 = to_list(V),
try
list_to_existing_atom(V1)
catch _:_ ->
list_to_atom(V1)
end.
> list_to_existing_atom is too restrictive as used by couch_rep
> -------------------------------------------------------------
>
> Key: COUCHDB-1004
> URL: https://issues.apache.org/jira/browse/COUCHDB-1004
> Project: CouchDB
> Issue Type: Bug
> Components: Replication
> Environment: erlang
> Reporter: Bob Dionne
> Priority: Minor
>
> We'd like to additional information to db_info in BigCouch, such as the Q and N constants for a given database. This causes replication to fail when replicating from BigCouch to CouchDB due to the use of list_to_existing_atom in couch_rep:dbinfo(...
> The claim is that list_to_atom pollutes the atoms table, however superficial testing indicates this is not the case, list_to_atom when called repeatedly seems to work fine. If this is true then consider reverting list_to_existing_atom back to list_to_atom.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.