Re: [PR] HIVE-28703: Integral Data Type Overflow Not Enforced for JsonSerDe and UDFs [hive]

["armitage420 (via GitHub)" <gi...@apache.org>]

armitage420 commented on code in PR #5608:
URL: https://github.com/apache/hive/pull/5608#discussion_r1978119971


##########
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java:
##########
@@ -124,10 +125,14 @@ public ByteWritable evaluate(ShortWritable i) {
    *          The integer value to convert
    * @return Byte
    */
-  public ByteWritable evaluate(IntWritable i) {
+  public ByteWritable evaluate(IntWritable i) throws UDFArgumentException {
     if (i == null) {
       return null;
     } else {
+      int value = i.get();
+      if (value < Byte.MIN_VALUE || value > Byte.MAX_VALUE) {
+        throw new UDFArgumentException("Value out of range for Byte: " + value);
+      }

Review Comment:
   Hey @okumin, thank you so much for the review!
   
   Your suggestion makes sense. I have set the default value as true.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org