You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "wornet-mwo (via GitHub)" <gi...@apache.org> on 2024/08/14 07:22:26 UTC

[PR] [linstor] Fix instance snapshot revert and delete on linstor storage [cloudstack]

wornet-mwo opened a new pull request, #9527:
URL: https://github.com/apache/cloudstack/pull/9527

   ### Description
   
   This PR is replacing `getUuid` on volume objects by `getPath`. It uses the uuid , when path is not set (which may happen in some cases.
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   Fixes: #9522 
   
   <!--- ******************************************************************************* -->
   <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ******************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [X] Major
   - [ ] Minor
   - [ ] Trivial
   
   ### How Has This Been Tested?
   
   Reproduced the issue using fresh instances on NFS storage. See linked issue for details.
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [linstor] Fix instance snapshot revert and delete on linstor storage [cloudstack]

Posted by "rp- (via GitHub)" <gi...@apache.org>.
rp- commented on PR #9527:
URL: https://github.com/apache/cloudstack/pull/9527#issuecomment-2288484428

   Here it is: https://github.com/apache/cloudstack/pull/9528


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [linstor] Fix instance snapshot revert and delete on linstor storage [cloudstack]

Posted by "rp- (via GitHub)" <gi...@apache.org>.
rp- commented on PR #9527:
URL: https://github.com/apache/cloudstack/pull/9527#issuecomment-2288181054

   I have an upcoming PR that fixes migrate primary storage to Linstor, which will have this fix included.
   Actually I wanted to submit the PR today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [linstor] Fix instance snapshot revert and delete on linstor storage [cloudstack]

Posted by "wornet-mwo (via GitHub)" <gi...@apache.org>.
wornet-mwo commented on PR #9527:
URL: https://github.com/apache/cloudstack/pull/9527#issuecomment-2288504105

   Thank you, closing here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [linstor] Fix instance snapshot revert and delete on linstor storage [cloudstack]

Posted by "wornet-mwo (via GitHub)" <gi...@apache.org>.
wornet-mwo commented on PR #9527:
URL: https://github.com/apache/cloudstack/pull/9527#issuecomment-2288216114

   @rp- In that case i would prefer your implementation before "refactoring" here as i'm pretty sure there are more similar calls in other places. Maybe you want to link the issue in your PR.
   
   It'd be nice to link it here before closing this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [linstor] Fix instance snapshot revert and delete on linstor storage [cloudstack]

Posted by "wornet-mwo (via GitHub)" <gi...@apache.org>.
wornet-mwo closed pull request #9527: [linstor] Fix instance snapshot revert and delete on linstor storage
URL: https://github.com/apache/cloudstack/pull/9527


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org