You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/03/10 15:26:38 UTC
[jira] [Commented] (SLING-4489) Sightly: Hyphenated identifiers
cause a compilation exception in Sightly generated Java classes
[ https://issues.apache.org/jira/browse/SLING-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354958#comment-14354958 ]
ASF GitHub Bot commented on SLING-4489:
---------------------------------------
GitHub user vladbailescu opened a pull request:
https://github.com/apache/sling/pull/68
SLING-4489 - Sightly: Hyphenated identifiers cause a compilation exception in Sightly generated Java classes
Added hyphen checks and parsing exception throwing.
Added integration tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladbailescu/sling SLING-4489-Sightly-Hyphenated-identifiers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit 2786d22c3263c58990dc71aa486e90457eb8065e
Author: vladbailescu <ba...@adobe.com>
Date: 2015-03-10T14:24:33Z
SLING-4489 - Sightly: Hyphenated identifiers cause a compilation exception in Sightly generated Java classes
Added hyphen checks and parsing exception throwing.
Added integration tests.
----
> Sightly: Hyphenated identifiers cause a compilation exception in Sightly generated Java classes
> -----------------------------------------------------------------------------------------------
>
> Key: SLING-4489
> URL: https://issues.apache.org/jira/browse/SLING-4489
> Project: Sling
> Issue Type: Bug
> Reporter: Vlad Bailescu
> Priority: Minor
>
> Using hyphenated identifiers leads to a compilation exception at runtime:
> {code:html}
> <template data-sly-template.bad-template="${ @ }">Test</template>
> {code}
> The Sightly grammar does not allow hyphenated identifier so a proper parsing exception should be thrown instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)