You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Justin Edelson (JIRA)" <ji...@apache.org> on 2011/07/20 22:47:57 UTC
[jira] [Created] (JCR-3029) JcrRemotingServlet should interpolate
system properties in the home init-param
JcrRemotingServlet should interpolate system properties in the home init-param
------------------------------------------------------------------------------
Key: JCR-3029
URL: https://issues.apache.org/jira/browse/JCR-3029
Project: Jackrabbit Content Repository
Issue Type: Improvement
Components: jackrabbit-jcr-server
Reporter: Justin Edelson
For deployment scenarios where the same Jackrabbit WAR file is deployed multiple times on the same server with the same current working directory, it is useful to have the home init-param support system property interpolation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3029) JcrRemotingServlet should interpolate
system properties in the home init-param
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081502#comment-13081502 ]
Jukka Zitting commented on JCR-3029:
------------------------------------
Sounds OK. I'll make another patch that uses java.io.tmpdir as the default, but keeps to the current behavior when the any of the init-params is present. That should cover Justin's needs as well as retaining backwards compatibility for existing configurations.
> JcrRemotingServlet should interpolate system properties in the home init-param
> ------------------------------------------------------------------------------
>
> Key: JCR-3029
> URL: https://issues.apache.org/jira/browse/JCR-3029
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-server
> Reporter: Justin Edelson
> Attachments: 0001-JCR-3029-JcrRemotingServlet-should-interpolate-syste.patch, JCR-3029.patch
>
>
> For deployment scenarios where the same Jackrabbit WAR file is deployed multiple times on the same server with the same current working directory, it is useful to have the home init-param support system property interpolation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3029) JcrRemotingServlet should interpolate
system properties in the home init-param
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson updated JCR-3029:
--------------------------------
Attachment: JCR-3029.patch
here's a patch
> JcrRemotingServlet should interpolate system properties in the home init-param
> ------------------------------------------------------------------------------
>
> Key: JCR-3029
> URL: https://issues.apache.org/jira/browse/JCR-3029
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-server
> Reporter: Justin Edelson
> Attachments: JCR-3029.patch
>
>
> For deployment scenarios where the same Jackrabbit WAR file is deployed multiple times on the same server with the same current working directory, it is useful to have the home init-param support system property interpolation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3029) JcrRemotingServlet should interpolate
system properties in the home init-param
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081477#comment-13081477 ]
angela commented on JCR-3029:
-----------------------------
hi jukka, i would prefer a patch that is backwards compatible but dealing with missing init-param. was that possible?
> JcrRemotingServlet should interpolate system properties in the home init-param
> ------------------------------------------------------------------------------
>
> Key: JCR-3029
> URL: https://issues.apache.org/jira/browse/JCR-3029
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-server
> Reporter: Justin Edelson
> Attachments: 0001-JCR-3029-JcrRemotingServlet-should-interpolate-syste.patch, JCR-3029.patch
>
>
> For deployment scenarios where the same Jackrabbit WAR file is deployed multiple times on the same server with the same current working directory, it is useful to have the home init-param support system property interpolation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3029) JcrRemotingServlet should interpolate
system properties in the home init-param
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081083#comment-13081083 ]
Justin Edelson commented on JCR-3029:
-------------------------------------
if this setting can be simply removed, that works for me.
> JcrRemotingServlet should interpolate system properties in the home init-param
> ------------------------------------------------------------------------------
>
> Key: JCR-3029
> URL: https://issues.apache.org/jira/browse/JCR-3029
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-server
> Reporter: Justin Edelson
> Attachments: 0001-JCR-3029-JcrRemotingServlet-should-interpolate-syste.patch, JCR-3029.patch
>
>
> For deployment scenarios where the same Jackrabbit WAR file is deployed multiple times on the same server with the same current working directory, it is useful to have the home init-param support system property interpolation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3029) JcrRemotingServlet should interpolate
system properties in the home init-param
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-3029:
-------------------------------
Attachment: 0001-JCR-3029-JcrRemotingServlet-should-interpolate-syste.patch
Is there really even a need for this configuration setting? I'd just use the standard java.io.tmpdir for temporary files and simply avoid the need for these configuration options. See the attached patch for the proposed change.
> JcrRemotingServlet should interpolate system properties in the home init-param
> ------------------------------------------------------------------------------
>
> Key: JCR-3029
> URL: https://issues.apache.org/jira/browse/JCR-3029
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-server
> Reporter: Justin Edelson
> Attachments: 0001-JCR-3029-JcrRemotingServlet-should-interpolate-syste.patch, JCR-3029.patch
>
>
> For deployment scenarios where the same Jackrabbit WAR file is deployed multiple times on the same server with the same current working directory, it is useful to have the home init-param support system property interpolation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3029) JcrRemotingServlet should interpolate
system properties in the home init-param
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-3029.
--------------------------------
Resolution: Fixed
Fix Version/s: 2.3.0
Assignee: Jukka Zitting
I modified the fix as proposed and committed the revised version in revision 1155403.
Now java.io.tmpdir gets used (as the default from DiskFileItemFactory) when neither the "home" nor the "temp-directory" init parameters are present. If either is set, then the temporary directory is constructed as before.
> JcrRemotingServlet should interpolate system properties in the home init-param
> ------------------------------------------------------------------------------
>
> Key: JCR-3029
> URL: https://issues.apache.org/jira/browse/JCR-3029
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-server
> Reporter: Justin Edelson
> Assignee: Jukka Zitting
> Fix For: 2.3.0
>
> Attachments: 0001-JCR-3029-JcrRemotingServlet-should-interpolate-syste.patch, JCR-3029.patch
>
>
> For deployment scenarios where the same Jackrabbit WAR file is deployed multiple times on the same server with the same current working directory, it is useful to have the home init-param support system property interpolation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira