You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "yunchipang (via GitHub)" <gi...@apache.org> on 2025/05/07 05:17:03 UTC
[PR] [WIP] transition of `list` airflowctl config command [airflow]
yunchipang opened a new pull request, #50292:
URL: https://github.com/apache/airflow/pull/50292
partially closes: #45664
parent issue: #45661
implements `list` config command by adding a `list` method to `ConfigOperations`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] transition of `list` airflowctl config command [airflow]
Posted by "yunchipang (via GitHub)" <gi...@apache.org>.
yunchipang commented on PR #50292:
URL: https://github.com/apache/airflow/pull/50292#issuecomment-2857087021
@bugraoz93 referencing our discussion in #49601, could you please take a look if this implementation of `airflowctl`'s `list` config command is on the right track?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] transition of `list` airflowctl config command [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #50292:
URL: https://github.com/apache/airflow/pull/50292#issuecomment-2864556842
Exactly, this is the case. In this one, directly calling the API endpoint is returning what we want, so only implementing the operations is enough in this case.
Format is okay for now, we are just using `rich.print()` for all generated ones, and we will do a bulk update later for formatting with one line below.
https://github.com/apache/airflow/blob/393668361b5fcb974df34a113d5b471ad1c7fa91/airflow-ctl/src/airflowctl/ctl/cli_config.py#L439
We only need to add and update a small part in the unit test for operations. Direction is good. Thanks for the update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] transition of `list` airflowctl config command [airflow]
Posted by "yunchipang (via GitHub)" <gi...@apache.org>.
yunchipang commented on PR #50292:
URL: https://github.com/apache/airflow/pull/50292#issuecomment-2860913206
@bugraoz93 Thanks for the review!
Just wanted to clarify—I was using the endpoint below to get all configs while implementing the `list` command, and it seemed to be working as expected:
https://github.com/apache/airflow/blob/393668361b5fcb974df34a113d5b471ad1c7fa91/airflow-core/src/airflow/api_fastapi/core_api/routes/public/config.py#L97-L98
This is the what the current `list` command gets me.
```
root@24ae150ff6a0:/opt/airflow# airflowctl config list
Please enter password for encrypted keyring:
Config(
sections=[
ConfigSection(
name='atlas',
options=[
ConfigOption(key='sasl_enabled', value='False'),
ConfigOption(key='host', value=''),
ConfigOption(key='port', value='21000'),
ConfigOption(key='username', value=''),
ConfigOption(key='password', value='')
]
),
ConfigSection(
name='hive',
options=[ConfigOption(key='default_hive_mapred_queue', value='')]
),
...
```
If the goal is to format it more like this:
```
[core]
dags_folder = /opt/airflow/dags
base_log_folder = /opt/airflow/logs
...
```
Would it be correct to assume this is just a matter of formatting? Or am I missing something deeper in the implementation? Happy to adjust if needed—just want to make sure I fully understand your feedback. Appreciate your insights!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Transition of `list` airflowctl config command [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 merged PR #50292:
URL: https://github.com/apache/airflow/pull/50292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org