[GitHub] [accumulo] milleruntime commented on a change in pull request #1100: Avoid locking in tserver when reading online tablets

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #1100: Avoid locking in tserver when reading online tablets
URL: https://github.com/apache/accumulo/pull/1100#discussion_r276833261
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
 ##########
 @@ -367,15 +365,13 @@ public TabletServer(ServerContext context) {
     this.replWorker = new ReplicationWorker(context, fs);
     this.statsKeeper = new TabletStatsKeeper();
     SimpleTimer.getInstance(aconf).schedule(() -> {
-      synchronized (onlineTablets) {
-        long now = System.currentTimeMillis();
-        for (Tablet tablet : onlineTablets.values())
-          try {
-            tablet.updateRates(now);
-          } catch (Exception ex) {
-            log.error("Error updating rates for {}", tablet.getExtent(), ex);
-          }
-      }
+      long now = System.currentTimeMillis();
 
 Review comment:
   Will dropping the sychronized block in the simple timer cause problems?  I am not sure how much of the SimpleTimer is shared and what we should worry about.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services