You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/04/08 19:34:49 UTC

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2820: [NETBEANS-189] Updates for Sql autocomplete WIP

matthiasblaesing commented on a change in pull request #2820:
URL: https://github.com/apache/netbeans/pull/2820#discussion_r610036176



##########
File path: ide/db.sql.editor/src/org/netbeans/modules/db/sql/editor/resources/layer.xml
##########
@@ -58,7 +58,7 @@
 
                 <folder name="FoldManager">
                     <file name="CustomFoldManager.instance">
-                	<attr name="position" intvalue="1200"/>
+                        <attr name="position" intvalue="1200"/>

Review comment:
       The reasoning is simple: Don't change things you don't need to change. Changing whitespace in places, that don't need an update just messes diffs. There are reasons to do this, this is not one of them.
   
   In general: Check the surrounding code - independent of any documentation new code should align with local conventions. If in doubt, I use default netbeans settings.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists