You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/26 14:33:41 UTC
[GitHub] [camel] chrisdutz opened a new pull request, #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
chrisdutz opened a new pull request, #8629:
URL: https://github.com/apache/camel/pull/8629
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
This is the donation of the Apache PLC4X Camel Integration Component. It allows to build Camel pipelines which read and write data from and to industrial equipment such as Programmable Logic Controllers.
However I could probably use some help in getting the module to build. I am currently getting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1301021138
We need to have a look at failing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1293574153
I pushed some updates to this branch
https://github.com/apache/camel/compare/chrisdutz-main
Now your component can compile and test. What is needed is to migrate to use `org.apache.camel.component.plc4x` as the package name. And some other cleanups we can do afterwards.
Not sure if you are able to work from that branch and continue. If not then lets see if we can find my commit and append to this PR or what it takes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1293699603
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 12 | 12 | 2 | 10 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1293575542
I also added some TODO in the source where you need to add description to what that option means and do for the end users to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1292147445
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] chrisdutz commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1301038309
Does "we" mean me? cause admittedly I tried finding what it's complaining about but couldn't really find it. I knew checkstyle was complaining about the imports being in the wrong order, however not telling me which the right order would be ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1296761150
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 1 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1302108911
This has been merged on main and it will be available in 3.20.0. Thanks for this.
We probably need to do some more work for supporting it as Spring Boot starter in camel-spring-boot, maybe as camel-karaf feature and probably as Kamelet too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1302026914
Working on merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd closed pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
oscerd closed pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
URL: https://github.com/apache/camel/pull/8629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] chrisdutz commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1293612422
Ok ... I pulled your changes and addressed at least two of the TODOs, asked for help by the PLC4X community on finalizing these descriptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1293707408
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 12 | 12 | 2 | 10 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] chrisdutz commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1296715264
Ok ... I've added the last missing two descriptions. As far as I see it, that was the last remaining TODO. Anything else you want me to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1301046694
It was a reminder for Camel contributors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] chrisdutz commented on pull request #8629: [CAMEL-18655] Integrate the Apache PLC4X Camel Integration module into the Apache Camel Project
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on PR #8629:
URL: https://github.com/apache/camel/pull/8629#issuecomment-1302121594
Thank you for your help in supporting me ... I am sure this will be beneficial for both of our projects :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org