You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/28 06:25:21 UTC
[GitHub] [flink] pnowojski commented on a change in pull request #12365: [FLINK-17988][checkpointing] Discard only unique channel state delegates
pnowojski commented on a change in pull request #12365:
URL: https://github.com/apache/flink/pull/12365#discussion_r431606416
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java
##########
@@ -231,8 +232,7 @@ public void discardState() {
toDispose.addAll(rawOperatorState);
toDispose.addAll(managedKeyedState);
toDispose.addAll(rawKeyedState);
- toDispose.addAll(inputChannelState);
- toDispose.addAll(resultSubpartitionState);
+ toDispose.addAll(collectUniqueDelegates(inputChannelState, resultSubpartitionState));
Review comment:
I think that's another place that would be better with FLINK-17972 - we could hide this logic inside the encapsulating `InFlightChannelStateHandle#discardState`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org