You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/10/17 04:47:20 UTC

[GitHub] [openwhisk] chetanmeh opened a new pull request #4692: Fix command examples for wskadmin-next

chetanmeh opened a new pull request #4692: Fix command examples for wskadmin-next
URL: https://github.com/apache/openwhisk/pull/4692
 
 
   Fixes the command examples used for wskadmin-next as identified in #4687
   
   ## Description
   
   `wskadmin-next` cli support differs in some forms from the python based `wskadmin` due to difference in argument parsing support used by backing libraries 
   
   1. `wskadmin-next` - [scallop](https://github.com/scallop/scallop)
   2. `wskadmin` - [argoarse](https://docs.python.org/3/library/argparse.html)
   
   Base difference
   
   1. `-ns` in `wskadmin` vs `--namespace` in `wskadmin-next` - Python support short args with single `-` while with scallop only supports single letter short form. Hence one need to use wither `-n` or better `--namespace`
   2. Argument positioning - Python support options after the trailing input like `user delete userB -ns space1`. With scallop we need to pass all the options first `user delete --namespace space1 userB`
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [ ] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services