You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/25 20:52:14 UTC
[GitHub] [solr] HoustonPutman opened a new pull request, #1129: SOLR-16416: Retry overseerPrioritizer ops on failure
HoustonPutman opened a new pull request, #1129:
URL: https://github.com/apache/solr/pull/1129
https://issues.apache.org/jira/browse/SOLR-16416
This should fix the failing test. No idea why the endpoints noted in the JIRA were unavailable when restarting the test nodes, but anyways it is good to retry this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1129: SOLR-16416: Retry overseerPrioritizer ops on failure
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1129:
URL: https://github.com/apache/solr/pull/1129#discussion_r1005095748
##########
solr/core/src/java/org/apache/solr/cloud/OverseerNodePrioritizer.java:
##########
@@ -133,6 +135,23 @@ public synchronized void prioritizeOverseerNodes(String overseerId) throws Excep
overseer.sendQuitToOverseer(OverseerTaskProcessor.getLeaderId(zkStateReader.getZkClient()));
}
+ private void invokeOverseerOpWithRetries(String electionNode, String op, int retryCount) {
+ boolean successful = false;
+ for (int i = 0; i < retryCount && !successful; i++) {
+ try {
+ invokeOverseerOp(electionNode, op);
+ successful = true;
+ } catch (SolrException e) {
+ if (i < retryCount - 1) {
Review Comment:
it looks like maybe a sleep was added then removed? not sure at least now there is no sleep?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1129: SOLR-16416: Retry overseerPrioritizer ops on failure
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1129:
URL: https://github.com/apache/solr/pull/1129#discussion_r1004960908
##########
solr/core/src/java/org/apache/solr/cloud/OverseerNodePrioritizer.java:
##########
@@ -133,6 +135,23 @@ public synchronized void prioritizeOverseerNodes(String overseerId) throws Excep
overseer.sendQuitToOverseer(OverseerTaskProcessor.getLeaderId(zkStateReader.getZkClient()));
}
+ private void invokeOverseerOpWithRetries(String electionNode, String op, int retryCount) {
+ boolean successful = false;
+ for (int i = 0; i < retryCount && !successful; i++) {
+ try {
+ invokeOverseerOp(electionNode, op);
+ successful = true;
+ } catch (SolrException e) {
+ if (i < retryCount - 1) {
Review Comment:
do we want some sort of sleep/wait here?
##########
solr/core/src/java/org/apache/solr/cloud/OverseerNodePrioritizer.java:
##########
@@ -20,7 +20,9 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
+
Review Comment:
`./gradlew tidy` most likely needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman merged pull request #1129: SOLR-16416: Retry overseerPrioritizer ops on failure
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged PR #1129:
URL: https://github.com/apache/solr/pull/1129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1129: SOLR-16416: Retry overseerPrioritizer ops on failure
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #1129:
URL: https://github.com/apache/solr/pull/1129#issuecomment-1291200682
@gerlowskija I have actually fixed the underlying issue. We were running overseer ops before actually registering all of the Solr handlers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a diff in pull request #1129: SOLR-16416: Retry overseerPrioritizer ops on failure
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on code in PR #1129:
URL: https://github.com/apache/solr/pull/1129#discussion_r1005143310
##########
solr/core/src/java/org/apache/solr/cloud/OverseerNodePrioritizer.java:
##########
@@ -133,6 +135,23 @@ public synchronized void prioritizeOverseerNodes(String overseerId) throws Excep
overseer.sendQuitToOverseer(OverseerTaskProcessor.getLeaderId(zkStateReader.getZkClient()));
}
+ private void invokeOverseerOpWithRetries(String electionNode, String op, int retryCount) {
+ boolean successful = false;
+ for (int i = 0; i < retryCount && !successful; i++) {
+ try {
+ invokeOverseerOp(electionNode, op);
+ successful = true;
+ } catch (SolrException e) {
+ if (i < retryCount - 1) {
Review Comment:
thanks for catching that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org