You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/02/16 11:10:49 UTC
[GitHub] [libcloud] Chaffelson opened a new pull request #1426: Minor
bugfix: ec2 driver create_node ex_userdata broken in tag 2.8
Chaffelson opened a new pull request #1426: Minor bugfix: ec2 driver create_node ex_userdata broken in tag 2.8
URL: https://github.com/apache/libcloud/pull/1426
## Minor bugfix: ec2 driver create_node ex_userdata broken in tag 2.8
### Description
Release tag 2.8 reworked the kwargs based implementation of the ec2 driver, introducing this error where the literal string 'ex_userdata' was passed during create_node intead of the actual ex_userdata kwarg
### Status
done, ready for review
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [x] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
Packaged tests are broken, tested manually using 3.0.0rc1
No change to documentation
No material change to code linting status
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami commented on issue #1426: Minor bugfix: ec2 driver
create_node ex_userdata broken in tag 2.8
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1426: Minor bugfix: ec2 driver create_node ex_userdata broken in tag 2.8
URL: https://github.com/apache/libcloud/pull/1426#issuecomment-586746347
Thanks and a good catch.
That was a bad bug :/
We also need to make sure we have some tests for this scenario to avoid such regressions in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] asfgit merged pull request #1426: Minor bugfix: ec2
driver create_node ex_userdata broken in tag 2.8
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1426: Minor bugfix: ec2 driver create_node ex_userdata broken in tag 2.8
URL: https://github.com/apache/libcloud/pull/1426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1426: Minor bugfix: ec2
driver create_node ex_userdata broken in tag 2.8
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1426: Minor bugfix: ec2 driver create_node ex_userdata broken in tag 2.8
URL: https://github.com/apache/libcloud/pull/1426#issuecomment-586694200
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1426?src=pr&el=h1) Report
> Merging [#1426](https://codecov.io/gh/apache/libcloud/pull/1426?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/8518aa0ee097632d1bd8255ccbdf911f6fb0f91d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/libcloud/pull/1426?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1426 +/- ##
=======================================
Coverage 86.08% 86.08%
=======================================
Files 370 370
Lines 77495 77495
Branches 7655 7655
=======================================
Hits 66710 66710
Misses 7885 7885
Partials 2900 2900
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1426?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/drivers/ec2.py](https://codecov.io/gh/apache/libcloud/pull/1426/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL2VjMi5weQ==) | `75.27% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1426?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1426?src=pr&el=footer). Last update [8518aa0...ea955ef](https://codecov.io/gh/apache/libcloud/pull/1426?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami commented on issue #1426: Minor bugfix: ec2 driver
create_node ex_userdata broken in tag 2.8
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1426: Minor bugfix: ec2 driver create_node ex_userdata broken in tag 2.8
URL: https://github.com/apache/libcloud/pull/1426#issuecomment-586750424
I've added a test case (5593d6cd0c06d1bb0416d157a89a956ba249092d) and merged it into trunk.
Thanks for contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services