You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/01/06 00:48:26 UTC
Review Request 41953: Exposed docker v1/v2 spec protobuf and headers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41953/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Timothy Chen.
Repository: mesos
Description
-------
Exposed docker v1/v2 spec protobuf and headers.
This will be exposed in ContainerConfig and passed to all isolators so that a docker isolator can properly isolate the runtime based on the image manifest returned from the provisioner.
Diffs
-----
include/mesos/docker/v1.hpp PRE-CREATION
include/mesos/docker/v2.hpp PRE-CREATION
src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
src/docker/spec.hpp 74968f2e776e52e3225db63c8dbd5b3c88a71c8f
src/docker/v1.hpp b7ec35f409d7b578d58f2150c56ff2e8c949da7c
src/docker/v1.proto
src/docker/v2.hpp 4b14969ff09bc3bd20cda8231e41f170fa52353d
src/docker/v2.proto 5d10bd3a6c077d34dd6921cdfd378b9fafe29a15
Diff: https://reviews.apache.org/r/41953/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 41953: Exposed docker v1/v2 spec protobuf and
headers.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41953/#review112973
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Jan. 5, 2016, 11:48 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41953/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 11:48 p.m.)
>
>
> Review request for mesos, Gilbert Song and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed docker v1/v2 spec protobuf and headers.
>
> This will be exposed in ContainerConfig and passed to all isolators so that a docker isolator can properly isolate the runtime based on the image manifest returned from the provisioner.
>
>
> Diffs
> -----
>
> include/mesos/docker/v1.hpp PRE-CREATION
> include/mesos/docker/v2.hpp PRE-CREATION
> src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
> src/docker/spec.hpp 74968f2e776e52e3225db63c8dbd5b3c88a71c8f
> src/docker/v1.hpp b7ec35f409d7b578d58f2150c56ff2e8c949da7c
> src/docker/v1.proto
> src/docker/v2.hpp 4b14969ff09bc3bd20cda8231e41f170fa52353d
> src/docker/v2.proto 5d10bd3a6c077d34dd6921cdfd378b9fafe29a15
>
> Diff: https://reviews.apache.org/r/41953/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 41953: Exposed docker v1/v2 spec protobuf and
headers.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41953/#review113005
-----------------------------------------------------------
Bad patch!
Reviews applied: [41953]
Failed command: ./support/apply-review.sh -n -r 41953
Error:
2016-01-06 03:34:34 URL:https://reviews.apache.org/r/41953/diff/raw/ [6983/6983] -> "41953.patch" [1]
error: include/mesos/docker/v1.hpp: already exists in index
error: include/mesos/docker/v2.hpp: already exists in index
error: patch failed: src/Makefile.am:174
error: src/Makefile.am: patch does not apply
error: patch failed: src/docker/spec.hpp:21
error: src/docker/spec.hpp: patch does not apply
error: patch failed: src/docker/v1.hpp:14
error: src/docker/v1.hpp: patch does not apply
error: src/docker/v1.proto: does not exist in index
error: patch failed: src/docker/v2.hpp:14
error: src/docker/v2.hpp: patch does not apply
error: src/docker/v2.proto: does not exist in index
- Mesos ReviewBot
On Jan. 5, 2016, 11:48 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41953/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 11:48 p.m.)
>
>
> Review request for mesos, Gilbert Song and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed docker v1/v2 spec protobuf and headers.
>
> This will be exposed in ContainerConfig and passed to all isolators so that a docker isolator can properly isolate the runtime based on the image manifest returned from the provisioner.
>
>
> Diffs
> -----
>
> include/mesos/docker/v1.hpp PRE-CREATION
> include/mesos/docker/v2.hpp PRE-CREATION
> src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
> src/docker/spec.hpp 74968f2e776e52e3225db63c8dbd5b3c88a71c8f
> src/docker/v1.hpp b7ec35f409d7b578d58f2150c56ff2e8c949da7c
> src/docker/v1.proto
> src/docker/v2.hpp 4b14969ff09bc3bd20cda8231e41f170fa52353d
> src/docker/v2.proto 5d10bd3a6c077d34dd6921cdfd378b9fafe29a15
>
> Diff: https://reviews.apache.org/r/41953/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>