You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pascal Borreli <pa...@borreli.com> on 2013/04/12 17:09:33 UTC
Review Request: Fixed Primary typo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10430/
-----------------------------------------------------------
Review request for cloudstack and Chip Childers.
Description
-------
Fixing typos "Primay" / "Primayr" to "Primary"
Diffs
-----
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/DirectAgentTest.java 2d6b94f
engine/storage/src/org/apache/cloudstack/storage/command/CreateVolumeFromBaseImageCommand.java f4be067
engine/storage/src/org/apache/cloudstack/storage/datastore/provider/DataStoreProviderManagerImpl.java 91b6c63
engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimaryDataStoreTO.java PRE-CREATION
engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimayDataStoreTO.java 18743d7
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageResource.java 9c29149
Diff: https://reviews.apache.org/r/10430/diff/
Testing
-------
Thanks,
Pascal Borreli
Re: Review Request: Fixed Primary typo
Posted by Pascal Borreli <pa...@borreli.com>.
> On April 12, 2013, 4:42 p.m., Chip Childers wrote:
> > Applied to master. If we want this in 4.1, we'll need a different patch, because the cherry-pick has conflicts. If you want to work through that locally, and then submit the correct patch, I'll happily apply to 4.1.
done https://reviews.apache.org/r/10431/
- Pascal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10430/#review19076
-----------------------------------------------------------
On April 12, 2013, 3:09 p.m., Pascal Borreli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10430/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 3:09 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> Fixing typos "Primay" / "Primayr" to "Primary"
>
>
> Diffs
> -----
>
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/DirectAgentTest.java 2d6b94f
> engine/storage/src/org/apache/cloudstack/storage/command/CreateVolumeFromBaseImageCommand.java f4be067
> engine/storage/src/org/apache/cloudstack/storage/datastore/provider/DataStoreProviderManagerImpl.java 91b6c63
> engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimaryDataStoreTO.java PRE-CREATION
> engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimayDataStoreTO.java 18743d7
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageResource.java 9c29149
>
> Diff: https://reviews.apache.org/r/10430/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pascal Borreli
>
>
Re: Review Request: Fixed Primary typo
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10430/#review19076
-----------------------------------------------------------
Ship it!
Applied to master. If we want this in 4.1, we'll need a different patch, because the cherry-pick has conflicts. If you want to work through that locally, and then submit the correct patch, I'll happily apply to 4.1.
- Chip Childers
On April 12, 2013, 3:09 p.m., Pascal Borreli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10430/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 3:09 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> Fixing typos "Primay" / "Primayr" to "Primary"
>
>
> Diffs
> -----
>
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/DirectAgentTest.java 2d6b94f
> engine/storage/src/org/apache/cloudstack/storage/command/CreateVolumeFromBaseImageCommand.java f4be067
> engine/storage/src/org/apache/cloudstack/storage/datastore/provider/DataStoreProviderManagerImpl.java 91b6c63
> engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimaryDataStoreTO.java PRE-CREATION
> engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimayDataStoreTO.java 18743d7
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageResource.java 9c29149
>
> Diff: https://reviews.apache.org/r/10430/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pascal Borreli
>
>