[jira] [Closed] (OFBIZ-9290) Have the ability to edit/remove terms of an invoice

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-9290.
----------------------------------
       Resolution: Implemented
    Fix Version/s: Upcoming Branch

Thanks Pierre, Akshay,

Akshay I committed a modified version of your patch at revision: 1857076

There was no need to create an EditInvoiceTerm screen, moreover it was quite wrong. Adding

{code:xml}
                <entity-one entity-name="InvoiceTerm" value-field="invoiceTerm">
                    <field-map field-name="invoiceTermId" from-field="parameters.invoiceTermId"/>
                </entity-one>
{code}
to InvoiceTerms was enough.

Also the way you handled the edit button in ListInvoiceTerms and the header of the EditInvoiceTerm were wrong, I guess related with your EditInvoiceTerm screen.

Finally I don't know why you separated the deleteInvoiceTerm and EditInvoiceTerm requests in the controller.

> Have the ability to edit/remove terms of an invoice
> ---------------------------------------------------
>
>                 Key: OFBIZ-9290
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9290
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release Branch 17.12, Release Branch 18.12
>            Reporter: Pierre Smits
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-9290.patch
>
>
> Currently the user has the ability to add terms to an invoice, but doesn't have the functions to edit or remove existing terms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)