You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Nikolaos Ballas <no...@github.com> on 2014/10/16 10:15:00 UTC

[jclouds-site] Update aws.md (#135)

You have to update a bit since the configuration as is doesn&#39;t work. This addition will make more clear the pom configuration the users must have in order for the simple code of mentioned below works fine.
You can merge this Pull Request by running:

  git pull https://github.com/cirix/jclouds-site patch-1

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-site/pull/135

-- Commit Summary --

  * Update aws.md

-- File Changes --

    M guides/aws.md (3)

-- Patch Links --

https://github.com/jclouds/jclouds-site/pull/135.patch
https://github.com/jclouds/jclouds-site/pull/135.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/135

Re: [jclouds-site] Update aws.md (#135)

Posted by Everett Toews <no...@github.com>.
Thanks for the updates @cirix! I had a couple of comments. Hope it's reasonable.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/135#issuecomment-59416677

Re: [jclouds-site] Update aws.md (#135)

Posted by Everett Toews <no...@github.com>.
> @@ -10,7 +10,8 @@ This page helps you get started with `jclouds` API with Amazon Web Services
>  2. Get your Access Key ID and Secret Access Key by going to this [page](https://aws-portal.amazon.com/gp/aws/developer/account/index.html?ie=UTF8&action=access-key).
>  3. Ensure you are using a recent JDK 6 version.
>  4. Setup your project to include aws-ec2 and aws-s3.
> -	* Get the dependencies `org.jclouds.provider/aws-ec2` and `org.jclouds.provider/aws-s3` using jclouds [Installation](/start/install).

I think we can leave this line the way it is. No need to change it.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/135/files#r18979790

Re: [jclouds-site] Update aws.md (#135)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #411](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/411/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/135#issuecomment-59328293

Re: [jclouds-site] Update aws.md (#135)

Posted by Everett Toews <no...@github.com>.
Closed #135.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/135#event-181271585

Re: [jclouds-site] Update aws.md (#135)

Posted by jclouds-commentator <no...@github.com>.
  Go to http://1f1e1e51e861c9419d89-26a5e7152a3cc473c5952d7a7642c8ea.r14.cf5.rackcdn.com/ to review your changes.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/135#issuecomment-59328485

Re: [jclouds-site] Update aws.md (#135)

Posted by Everett Toews <no...@github.com>.
> @@ -10,7 +10,8 @@ This page helps you get started with `jclouds` API with Amazon Web Services
>  2. Get your Access Key ID and Secret Access Key by going to this [page](https://aws-portal.amazon.com/gp/aws/developer/account/index.html?ie=UTF8&action=access-key).
>  3. Ensure you are using a recent JDK 6 version.
>  4. Setup your project to include aws-ec2 and aws-s3.
> -	* Get the dependencies `org.jclouds.provider/aws-ec2` and `org.jclouds.provider/aws-s3` using jclouds [Installation](/start/install).
> +	* Get the dependencies `org.jclouds.provider/aws-ec2` and `org.jclouds.provider/aws-s3` using jclouds
> +	* In order to be able to use the SshjSshClientModule etc you need in your maven configuration apart from the jclouds-all 	to include also the org.jclouds.driver groupId and then include the jclouds-sshj artifact.

Can you make this line read more like the line above?

For example,

    In order to be able to use the SshjSshClientModule, you also need to get the dependency `org.jclouds.driver/jclouds-sshj`.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/135/files#r18979996