You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by yi...@apache.org on 2019/08/03 06:01:16 UTC
[royale-asjs] 01/01: Stub for fix for SkinnableTextBase issues
This is an automated email from the ASF dual-hosted git repository.
yishayw pushed a commit to branch skinnable_text_base
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit d31b813b832ce5cb5e3972284a0a01bbb0607393
Author: DESKTOP-RH4S838\Yishay <yi...@hotmail.com>
AuthorDate: Sat Aug 3 09:00:43 2019 +0300
Stub for fix for SkinnableTextBase issues
---
.../SparkRoyale/src/main/royale/spark/components/TextInput.as | 3 +++
.../royale/spark/components/supportClasses/SkinnableTextBase.as | 8 ++++----
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/TextInput.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/TextInput.as
index 26c0ab5..e5b9079 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/TextInput.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/TextInput.as
@@ -293,6 +293,7 @@ public class TextInput extends SkinnableTextBase
*/
override public function set text(value:String):void
{
+ // BEGIN - this code shouldn't exist once SkinnableTextBase is fixed
COMPILE::SWF
{
inSetter = true;
@@ -304,7 +305,9 @@ public class TextInput extends SkinnableTextBase
{
(element as HTMLInputElement).value = value;
}
+ // END
+ super.text = value;
// Trigger bindings to textChanged.
dispatchEvent(new Event("textChanged"));
}
diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableTextBase.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableTextBase.as
index bd826d3..a72ee2f 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableTextBase.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableTextBase.as
@@ -47,11 +47,11 @@ import spark.components.Application;
import spark.components.RichEditableText;
import spark.components.TextSelectionHighlighting;
import spark.core.IDisplayText;
-import spark.core.IEditableText;
import spark.core.IProxiedStageTextWrapper;
import spark.core.ISoftKeyboardHintClient;
import spark.events.TextOperationEvent;
*/
+import spark.core.IEditableText;
import mx.managers.IFocusManagerComponent;
import org.apache.royale.events.Event;
import org.apache.royale.events.MouseEvent;
@@ -606,7 +606,7 @@ public class SkinnableTextBase extends SkinnableComponent
* @playerversion AIR 1.5
* @productversion Royale 0.9.4
*/
- // public var textDisplay:IEditableText;
+ public var textDisplay:IEditableText;
/**
* @private
@@ -1504,7 +1504,7 @@ public class SkinnableTextBase extends SkinnableComponent
{
// text should never be null. Convert null to the empty string.
- /* if (textDisplay)
+ if (textDisplay)
{
textDisplay.text = value;
textDisplayProperties = BitFlagUtil.update(
@@ -1523,7 +1523,7 @@ public class SkinnableTextBase extends SkinnableComponent
// Generate an UPDATE_COMPLETE event.
invalidateProperties();
- invalidateSkinState(); */
+ invalidateSkinState();
}
//----------------------------------