You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/08 22:41:19 UTC
[GitHub] [lucene-solr] thelabdude opened a new pull request #2328: SOLR-15145: System property to control whether base_url is stored in state.json to enable back-compat with older SolrJ versions
thelabdude opened a new pull request #2328:
URL: https://github.com/apache/lucene-solr/pull/2328
# Description
Fix for https://issues.apache.org/jira/browse/SOLR-15145
# Solution
Unfortunately, we don't have a lot of options with this issue. We could just go back to storing `base_url` but I like the system property (could add an ENV var too) for installations that can upgrade their SolrJ to 8.8 as it helps get them closer to Solr 9.x where we don't store `base_url` but also gives the possibility to run an older SolrJ client version against an upgraded Solr 8.8 server.
# Tests
Tests still TBD ...
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] thelabdude merged pull request #2328: SOLR-15145: System property to control whether base_url is stored in state.json to enable back-compat with older SolrJ versions
Posted by GitBox <gi...@apache.org>.
thelabdude merged pull request #2328:
URL: https://github.com/apache/lucene-solr/pull/2328
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] thelabdude commented on pull request #2328: SOLR-15145: System property to control whether base_url is stored in state.json to enable back-compat with older SolrJ versions
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #2328:
URL: https://github.com/apache/lucene-solr/pull/2328#issuecomment-776287188
I ran a back-compat test with a client app built with SolrJ 8.7.0 and a server from this branch and it works as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] anshumg commented on a change in pull request #2328: SOLR-15145: System property to control whether base_url is stored in state.json to enable back-compat with older SolrJ versions
Posted by GitBox <gi...@apache.org>.
anshumg commented on a change in pull request #2328:
URL: https://github.com/apache/lucene-solr/pull/2328#discussion_r573145918
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkNodeProps.java
##########
@@ -118,14 +120,9 @@ public static ZkNodeProps load(byte[] bytes) {
@Override
public void write(JSONWriter jsonWriter) {
// don't write out the base_url if we have a node_name
Review comment:
Perhaps also add to the comment about the `STORE_BASE_URL` flag ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org