You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2016/10/04 16:37:41 UTC
Review Request 52518: GEODE-1963: Add lucene xsd to website
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52518/
-----------------------------------------------------------
Review request for geode, Joey McAllister, William Markito, and Dan Smith.
Repository: geode
Description
-------
Lucene xsd should be added to the website. This is checking in the xsd into source control, after checking this in, I would generate/replace the website content on the asf-site branch
Diffs
-----
geode-site/website/content/schema/cache/lucene-1.0.xsd PRE-CREATION
Diff: https://reviews.apache.org/r/52518/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 52518: GEODE-1963: Add lucene xsd to website
Posted by Joey McAllister <jm...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52518/#review151350
-----------------------------------------------------------
Ship it!
Ship It!
- Joey McAllister
On Oct. 4, 2016, 4:37 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52518/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2016, 4:37 p.m.)
>
>
> Review request for geode, Joey McAllister, William Markito, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Lucene xsd should be added to the website. This is checking in the xsd into source control, after checking this in, I would generate/replace the website content on the asf-site branch
>
>
> Diffs
> -----
>
> geode-site/website/content/schema/cache/lucene-1.0.xsd PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52518/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 52518: GEODE-1963: Add lucene xsd to website
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52518/#review151348
-----------------------------------------------------------
Ship it!
It's a little unfortunate to have two copies of these xsd files checked in. Long term I think we need to keep only one version of the xsds checked in and bundle them in both the source and the website.
- Dan Smith
On Oct. 4, 2016, 4:37 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52518/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2016, 4:37 p.m.)
>
>
> Review request for geode, Joey McAllister, William Markito, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Lucene xsd should be added to the website. This is checking in the xsd into source control, after checking this in, I would generate/replace the website content on the asf-site branch
>
>
> Diffs
> -----
>
> geode-site/website/content/schema/cache/lucene-1.0.xsd PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52518/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>