[GitHub] [incubator-superset] rusackas commented on a change in pull request #12008: feat(explore-datasource): add new datasource tab to explore view

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #12008:
URL: https://github.com/apache/incubator-superset/pull/12008#discussion_r544710912



##########
File path: superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
##########
@@ -40,26 +39,13 @@ const defaultProps = {
   onSave: () => {},
 };
 
-// Prolly need to move this to a global context

Review comment:
       Heya... I took those out. At least for me, most of them don't actually work, so I figured it wouldn't be missed.
   
   We can certainly put it back in if it's a big deal, but I'd rather design/implement a more global keyboard shortcut helper, e.g. hover/click a global item, and all the bits of UI with keyboard shortcuts light up. For example, the Run button would get a litte `ctrl-r` tooltip next to it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org