You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2025/01/30 08:16:28 UTC
[PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
hainenber opened a new pull request, #32035:
URL: https://github.com/apache/superset/pull/32035
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
fix(fe/dashboard-list): display modifier info for `Last modified` data
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fix #31258
The tooltip showing modifier data on `Last modified` cell is now restored. I'll add a E2E test real quick on this one
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
To be added
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: 31258
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #32035:
URL: https://github.com/apache/superset/pull/32035#issuecomment-2623812344
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment `/korbit-review`.
> Your admin can change your review schedule in the [Korbit Console](https://app.korbit.ai/settings)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #32035:
URL: https://github.com/apache/superset/pull/32035#issuecomment-2640301384
Thanks for this fix! Did you see that in the issue, I identified what I think is an end-to-end test that failed to catch this regression? If my assessment is correct - I'm new to that part of the project - it would be ideal if this test got updated to avoid such a regression in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #32035:
URL: https://github.com/apache/superset/pull/32035#discussion_r1965880317
##########
superset-frontend/src/pages/DashboardList/index.tsx:
##########
@@ -118,12 +118,13 @@ const DASHBOARD_COLUMNS_TO_FETCH = [
'published',
'url',
'slug',
- 'changed_by',
+ 'changed_by.id',
+ 'changed_by.first_name',
+ 'changed_by.last_name',
'changed_on_delta_humanized',
'owners.id',
'owners.first_name',
'owners.last_name',
- 'owners',
Review Comment:
Re-added old nested fields. Issue is still fixed with less risks :D
<img width="1313" alt="image" src="https://github.com/user-attachments/assets/e2e7bdd3-a509-4436-bb1c-67df4b5dfc9b" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #32035:
URL: https://github.com/apache/superset/pull/32035#discussion_r1965833096
##########
superset-frontend/src/pages/DashboardList/index.tsx:
##########
@@ -118,12 +118,13 @@ const DASHBOARD_COLUMNS_TO_FETCH = [
'published',
'url',
'slug',
- 'changed_by',
+ 'changed_by.id',
+ 'changed_by.first_name',
+ 'changed_by.last_name',
'changed_on_delta_humanized',
'owners.id',
'owners.first_name',
'owners.last_name',
- 'owners',
Review Comment:
The attributes like `owners.last_name` are the one populating the owners field. For some reasons, you have to specify atributes for nested fields like `owners` and `changed_by`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #32035:
URL: https://github.com/apache/superset/pull/32035#discussion_r1965863060
##########
superset-frontend/src/pages/DashboardList/index.tsx:
##########
@@ -118,12 +118,13 @@ const DASHBOARD_COLUMNS_TO_FETCH = [
'published',
'url',
'slug',
- 'changed_by',
+ 'changed_by.id',
+ 'changed_by.first_name',
+ 'changed_by.last_name',
'changed_on_delta_humanized',
'owners.id',
'owners.first_name',
'owners.last_name',
- 'owners',
Review Comment:
Maybe you misunderstood what I mean. Previously, we had `owners` being declared which means that ALL attributes of `owners` were accessible like `full_name`. Now that you excluded `owners` from the fetched columns, if there's some component accessing `full_name`, it will break. I'm ok with removing the whole owners object but we need to check which attributes are in fact being used so that the projection is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #32035:
URL: https://github.com/apache/superset/pull/32035#issuecomment-2654422571
Got it @hainenber - thanks for explaining that and thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #32035:
URL: https://github.com/apache/superset/pull/32035#discussion_r1965823858
##########
superset-frontend/src/pages/DashboardList/index.tsx:
##########
@@ -118,12 +118,13 @@ const DASHBOARD_COLUMNS_TO_FETCH = [
'published',
'url',
'slug',
- 'changed_by',
+ 'changed_by.id',
+ 'changed_by.first_name',
+ 'changed_by.last_name',
'changed_on_delta_humanized',
'owners.id',
'owners.first_name',
'owners.last_name',
- 'owners',
Review Comment:
@hainenber Can you confirm that the owners' fields, apart from `id`, `first_name` and `last_name`, are not being used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #32035:
URL: https://github.com/apache/superset/pull/32035#discussion_r1965867879
##########
superset-frontend/src/pages/DashboardList/index.tsx:
##########
@@ -118,12 +118,13 @@ const DASHBOARD_COLUMNS_TO_FETCH = [
'published',
'url',
'slug',
- 'changed_by',
+ 'changed_by.id',
+ 'changed_by.first_name',
+ 'changed_by.last_name',
'changed_on_delta_humanized',
'owners.id',
'owners.first_name',
'owners.last_name',
- 'owners',
Review Comment:
I see. Then in that case, I'll only add the missing attributes and not to remove the nested field names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #32035:
URL: https://github.com/apache/superset/pull/32035#discussion_r1965823858
##########
superset-frontend/src/pages/DashboardList/index.tsx:
##########
@@ -118,12 +118,13 @@ const DASHBOARD_COLUMNS_TO_FETCH = [
'published',
'url',
'slug',
- 'changed_by',
+ 'changed_by.id',
+ 'changed_by.first_name',
+ 'changed_by.last_name',
'changed_on_delta_humanized',
'owners.id',
'owners.first_name',
'owners.last_name',
- 'owners',
Review Comment:
@hainenber Can you confirm that the `owners`' fields, apart from `id`, `first_name` and `last_name`, are not being used? Same for `changed_by`'s fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #32035:
URL: https://github.com/apache/superset/pull/32035#issuecomment-2651105464
@sfirke the linked test is not an E2E one though, it's a component test. I'd like to add an E2E test to cover this regression but Cypress doesn't _really_ support hovering so it's a real hassle atm. Once we migrated to Playwright, it'll be a breeze instead. Hope this helps!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #32035:
URL: https://github.com/apache/superset/pull/32035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(fe/dashboard-list): display modifier info for `Last modified` data [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #32035:
URL: https://github.com/apache/superset/pull/32035#discussion_r1965867879
##########
superset-frontend/src/pages/DashboardList/index.tsx:
##########
@@ -118,12 +118,13 @@ const DASHBOARD_COLUMNS_TO_FETCH = [
'published',
'url',
'slug',
- 'changed_by',
+ 'changed_by.id',
+ 'changed_by.first_name',
+ 'changed_by.last_name',
'changed_on_delta_humanized',
'owners.id',
'owners.first_name',
'owners.last_name',
- 'owners',
Review Comment:
I see. Then in that case, I'll only add the missing attributes and not to remove the nested field names to minimize any risks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org