You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dhams <gi...@git.apache.org> on 2016/02/19 12:36:58 UTC
[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...
GitHub user dhams opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/85
CB-10643cordova plugin splashscreen : Added new preference to choose whether dialog is cancelable or not.
Added option to choose whether developer wants cancelable dialog or not while loading splashscreen.
I added preference `<preference name="spinnerCancelable" value="true|false" /> ` in config.xml where user can set appropriate value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Accenture/cordova-plugin-splashscreen CB-10643cordova-plugin-splashscreen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit d82b76cba98915612be960d9f66891584dfb215b
Author: bbadrinath <bb...@users.noreply.github.com>
Date: 2016-02-10T06:56:29Z
Merge pull request #1 from apache/master
Rebasing the forked branch from 3.1.1 to current master branch 3.2.0
commit cef829bac947f734f3d50e727d91eb41827fdc57
Author: Sharma <dh...@accenture.com>
Date: 2016-02-19T11:32:19Z
Added new preference to choose whether dialog is cancelable or not.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #85: CB-10643cordova plugin splashscreen :...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/85
I'm going to close this, since the scenario hasn't been explained, and there has been inactivity on this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53503210
--- Diff: src/android/SplashScreen.java ---
@@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog) {
}
});
- spinnerDialog.setCancelable(false);
+ if(preferences.getBoolean("spinnerCancelable",true)){
--- End diff --
Why a user would need to cancel the spinner? This will not dismiss the splashscreen itself.
Could you please explain what is your scenario?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/85#issuecomment-186184171
Thanks!
Could you please explain your use case why the spinner should be cancellable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53451788
--- Diff: src/android/SplashScreen.java ---
@@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog) {
}
});
- spinnerDialog.setCancelable(false);
+ if(preferences.getBoolean("spinnerCancelable",true)){
--- End diff --
Should not the property be `false` by default (noncancellable)?
You are changing the default plugin behavior as it is optional.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...
Posted by dhams <gi...@git.apache.org>.
Github user dhams commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53453538
--- Diff: src/android/SplashScreen.java ---
@@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog) {
}
});
- spinnerDialog.setCancelable(false);
+ if(preferences.getBoolean("spinnerCancelable",true)){
--- End diff --
That may give a more privilege to developer I guess.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request #85: CB-10643cordova plugin splashs...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/85
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org