You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/07/12 02:52:47 UTC
[kudu-CR] tablet: add second snapshot to iterator options
Hello Mike Percy, Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10925
to review the following change.
Change subject: tablet: add second snapshot to iterator options
......................................................................
tablet: add second snapshot to iterator options
This commit adds a second snapshot parameter called 'snap_to_exclude' and
renames the existing snapshot to 'snap_to_include'. The new snapshot is
hidden behind a boost::optional so that ignoring it is more efficient (i.e.
a call to boost::optional::is_initialized() instead of
MvccSnapshot::IsCommitted() on a snapshot including all transactions).
Taken together, the two snapshots form a time range. If both are set, the
iterator should only show transactions committed in 'snap_to_include' and
not committed in 'snap_to_exclude'. This will be used in the upcoming diff
scan API, which needs to produce results between two HT timestamps.
Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet.cc
12 files changed, 41 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/10925/1
--
To view, visit http://gerrit.cloudera.org:8080/10925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
Gerrit-Change-Number: 10925
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tablet: add second snapshot to iterator options
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10925 )
Change subject: tablet: add second snapshot to iterator options
......................................................................
tablet: add second snapshot to iterator options
This commit adds a second snapshot parameter called 'snap_to_exclude' and
renames the existing snapshot to 'snap_to_include'. The new snapshot is
hidden behind a boost::optional so that ignoring it is more efficient (i.e.
a call to boost::optional::is_initialized() instead of
MvccSnapshot::IsCommitted() on a snapshot including all transactions).
Taken together, the two snapshots form a time range. If both are set, the
iterator should only show transactions committed in 'snap_to_include' and
not committed in 'snap_to_exclude'. This will be used in the upcoming diff
scan API, which needs to produce results between two HT timestamps.
Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
Reviewed-on: http://gerrit.cloudera.org:8080/10925
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet.cc
12 files changed, 41 insertions(+), 33 deletions(-)
Approvals:
Adar Dembo: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
Gerrit-Change-Number: 10925
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tablet: add second snapshot to iterator options
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10925 )
Change subject: tablet: add second snapshot to iterator options
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
Gerrit-Change-Number: 10925
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 19 Jul 2018 22:05:06 +0000
Gerrit-HasComments: No
[kudu-CR] tablet: add second snapshot to iterator options
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10925 )
Change subject: tablet: add second snapshot to iterator options
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
Gerrit-Change-Number: 10925
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 19 Jul 2018 17:27:23 +0000
Gerrit-HasComments: No
[kudu-CR] tablet: add second snapshot to iterator options
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10925 )
Change subject: tablet: add second snapshot to iterator options
......................................................................
Patch Set 4: Verified+1
Overriding Jenkins, unrelated test failures.
--
To view, visit http://gerrit.cloudera.org:8080/10925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
Gerrit-Change-Number: 10925
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 19 Jul 2018 21:38:56 +0000
Gerrit-HasComments: No
[kudu-CR] tablet: add second snapshot to iterator options
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10925
to look at the new patch set (#2).
Change subject: tablet: add second snapshot to iterator options
......................................................................
tablet: add second snapshot to iterator options
This commit adds a second snapshot parameter called 'snap_to_exclude' and
renames the existing snapshot to 'snap_to_include'. The new snapshot is
hidden behind a boost::optional so that ignoring it is more efficient (i.e.
a call to boost::optional::is_initialized() instead of
MvccSnapshot::IsCommitted() on a snapshot including all transactions).
Taken together, the two snapshots form a time range. If both are set, the
iterator should only show transactions committed in 'snap_to_include' and
not committed in 'snap_to_exclude'. This will be used in the upcoming diff
scan API, which needs to produce results between two HT timestamps.
Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet.cc
12 files changed, 41 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/10925/2
--
To view, visit http://gerrit.cloudera.org:8080/10925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
Gerrit-Change-Number: 10925
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tablet: add second snapshot to iterator options
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10925 )
Change subject: tablet: add second snapshot to iterator options
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: If4f7390671a637962cc2e3851e8be0e3a6982b17
Gerrit-Change-Number: 10925
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>