[GitHub] [helix] rabashizade commented on a diff in pull request #2103: Add TTL and Container modes to RealmAwareZkClient and its implementations

[GitBox <gi...@apache.org>]

rabashizade commented on code in PR #2103:
URL: https://github.com/apache/helix/pull/2103#discussion_r877308648


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/RealmAwareZkClient.java:
##########
@@ -175,10 +175,34 @@ void unsubscribeStateChanges(
 
   void createPersistent(String path, Object data, List<ACL> acl);
 
+  void createPersistentWithTTL(String path, long ttl);

Review Comment:
   I think this is a case-by-case situation. I'd say ideally, yes, but for this particular set of API, we have known use-cases that need these features so that's why I started adding them. In fact, they have been available in open-source Zookeeper for quite a while now, but we hadn't added them until now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org