You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/10/13 15:08:32 UTC
[GitHub] [pulsar] kellyfj opened a new pull request #12352: Documentation: Clarify units on load balancing metrics
kellyfj opened a new pull request #12352:
URL: https://github.com/apache/pulsar/pull/12352
Clarify which units to use when graphing these metrics
### Motivation
Not clear whether bytes in / out was in units of bytes, or memory also in bytes etc.
### Modifications
Added information on the units
### Verifying this change
Small documentatin change
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies: no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
### Documentation
Need to update docs?
- [ X] doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #12352: Documentation: Clarify units on load balancing metrics
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #12352:
URL: https://github.com/apache/pulsar/pull/12352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kellyfj commented on a change in pull request #12352: Documentation: Clarify units on load balancing metrics
Posted by GitBox <gi...@apache.org>.
kellyfj commented on a change in pull request #12352:
URL: https://github.com/apache/pulsar/pull/12352#discussion_r732758486
##########
File path: site2/docs/reference-metrics.md
##########
@@ -307,11 +307,11 @@ All the loadbalancing metrics are labelled with the following labels:
| Name | Type | Description |
| --- | --- | --- |
-| pulsar_lb_bandwidth_in_usage | Gauge | The broker bandwith in usage |
-| pulsar_lb_bandwidth_out_usage | Gauge | The broker bandwith out usage |
-| pulsar_lb_cpu_usage | Gauge | The broker cpu usage |
-| pulsar_lb_directMemory_usage | Gauge | The broker process direct memory usage |
-| pulsar_lb_memory_usage | Gauge | The broker process memory usage |
+| pulsar_lb_bandwidth_in_usage | Gauge | The broker bandwith in usage. Units are percent. |
Review comment:
Thanks @Anonymitaet I like your idea - but I will replace `bandwidth in` with `inbound bandwidth` to keep clarity. And make the similar change for `bandwidth out` to `outbound bandwidth`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #12352: Documentation: Clarify units on load balancing metrics
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #12352:
URL: https://github.com/apache/pulsar/pull/12352#discussion_r728579159
##########
File path: site2/docs/reference-metrics.md
##########
@@ -307,11 +307,11 @@ All the loadbalancing metrics are labelled with the following labels:
| Name | Type | Description |
| --- | --- | --- |
-| pulsar_lb_bandwidth_in_usage | Gauge | The broker bandwith in usage |
-| pulsar_lb_bandwidth_out_usage | Gauge | The broker bandwith out usage |
-| pulsar_lb_cpu_usage | Gauge | The broker cpu usage |
-| pulsar_lb_directMemory_usage | Gauge | The broker process direct memory usage |
-| pulsar_lb_memory_usage | Gauge | The broker process memory usage |
+| pulsar_lb_bandwidth_in_usage | Gauge | The broker bandwith in usage. Units are percent. |
Review comment:
Maybe "xxx usage in terms of percentage." is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org