[jira] [Commented] (KYLIN-3588) Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map

["jiatao.tao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626866#comment-16626866 ] 

jiatao.tao commented on KYLIN-3588:
-----------------------------------

seems a synchronized can deal with this.

> Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map
> -----------------------------------------------------------------------
>
>                 Key: KYLIN-3588
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3588
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: jiatao.tao
>            Priority: Minor
>
> Here is related code:
> {code}
>         IRealizationFilter filter = filters.get(conf);
>         if (filter == null) {
>             try {
>                 Class<? extends IRealizationFilter> clz = ClassUtil.forName(conf.getQueryRealizationFilter(), IRealizationFilter.class);
>                 filter = clz.getConstructor(KylinConfig.class).newInstance(conf);
>             } catch (Exception e) {
>                 throw new RuntimeException(e);
>             }
>             filters.put(conf, filter);
> {code}
> Two threads may find out there is no filter for conf, they would proceed with creation of IRealizationFilter instances and try to put into the map.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)