[jira] Commented: (HARMONY-12) [BootJVM] MakeSetup contains an uncorrectly escaped shell command

["Bootstrap JVM (Daniel Lydick) (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/HARMONY-12?page=comments#action_12357336 ] 

Bootstrap JVM (Daniel Lydick) commented on HARMONY-12:
------------------------------------------------------

This correction was made to 'MakeSetup'
in SVN revision 330881 while other changes
were being made, which included this file
being moved to become 'support/MakeSetup'.
Both the edit and the location may be seen in
the SVN commit notice:

--- incubator/harmony/enhanced/trunk/sandbox/contribs/bootjvm/bootJVM/MakeSetup (original)
+++ incubator/harmony/enhanced/trunk/sandbox/contribs/bootjvm/bootJVM/support/MakeSetup Fri Nov  4 12:16:42 2005
@@ -1,12 +1,12 @@
#
#!
-# @file ./MakeSetup
+# @file support/MakeSetup
#
# @brief Setup and configuration of all Makefiles
#
# @see @link ./Makefile ./Makefile@endlink
#
-# @see @link ./MakeRules ./MakeRules@endlink
+# @see @link support/MakeRules support/MakeRules@endlink
#
#
# @section Control
@@ -62,21 +62,16 @@
########################
#
-# Base name of this directory and of parent directory
+# Base name of this directory
#
-DIRNAME:=$(shell expr $(PWD) : '\(.*[^/]\)/*$' : '.*/\(..*\)')
-PROJECTNAME:=
-
-ifeq ("src","$(DIRNAME)")
-PROJECTNAME:=$(shell expr $(PWD)/ : '\(/\)/*[^/]*//*$' \| $(PWD)/ \
-                                  : '\(.*[^/]\)//*[^/][^/]*//*$' )
-endif
+DIRNAME:=$(shell expr $(PWD) : '\(.*[^/]\)/*$$' : '.*/\(..*\)')
########################
#
... snip...

Thanks, Jean-Frederic, for finding this and correcting it.


> [BootJVM] MakeSetup contains an uncorrectly escaped shell command
> -----------------------------------------------------------------
>
>          Key: HARMONY-12
>          URL: http://issues.apache.org/jira/browse/HARMONY-12
>      Project: Harmony
>         Type: Bug
>   Components: VM
>  Environment: any
>     Reporter: Jean-Frederic Clere
>     Assignee: Geir Magnusson Jr
>  Attachments: MakeSetup.patch
>
> DIRNAME:=$(shell expr $(PWD) : '\(.*[^/]\)/*$' : '.*/\(..*\)')
> should be
> DIRNAME:=$(shell expr $(PWD) : '\(.*[^/]\)/*$$' : '.*/\(..*\)')

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira