You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/17 17:39:23 UTC

[GitHub] [arrow] pitrou opened a new pull request, #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

pitrou opened a new pull request, #14666:
URL: https://github.com/apache/arrow/pull/14666

   `std::to_chars` is locale-independent unlike `std::to_string`; it may also be faster in some cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1318990699

   Darn, `std::to_chars` is not implemented for floating-point on all C++ standard libraries :-(
   https://stackoverflow.com/questions/63963961/what-is-the-correct-way-to-call-stdto-chars


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] wgtmac commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
wgtmac commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1326033125

   On my Mac M1 laptop, the compilation looks good but linking complains about undefined symbols:
   ```
   [ 63%] Built target arrow-io-file-test
   [ 63%] Built target arrow-io-memory-test
   [ 63%] Linking CXX executable ../../../debug/arrow-utility-test
   Undefined symbols for architecture arm64:
     "std::__1::to_chars(char*, char*, double)", referenced from:
         std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > arrow::internal::ToChars<double>(double) in string_test.cc.o
     "std::__1::to_chars(char*, char*, float)", referenced from:
         std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > arrow::internal::ToChars<float>(float) in string_test.cc.o
   ld: symbol(s) not found for architecture arm64
   clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
   make[2]: *** [debug/arrow-utility-test] Error 1
   make[1]: *** [src/arrow/util/CMakeFiles/arrow-utility-test.dir/all] Error 2
   make: *** [all] Error 2
   ``` 
   
   It looks like I am hitting an old issue: https://stackoverflow.com/questions/58923623/stdto-chars-compile-but-not-linking-on-macos-clang/59672017#59672017
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] westonpace commented on a diff in pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
westonpace commented on code in PR #14666:
URL: https://github.com/apache/arrow/pull/14666#discussion_r1025684123


##########
cpp/src/arrow/util/string.h:
##########
@@ -97,5 +100,31 @@ std::optional<std::string> Replace(std::string_view s, std::string_view token,
 ARROW_EXPORT
 arrow::Result<bool> ParseBoolean(std::string_view value);
 
+/// \brief An ergonomic wrapper around std::to_chars, returning a std::string
+///
+/// For most inputs, the std::string result will not incur any heap allocation
+/// thanks to small string optimization.
+///
+/// Compared to std::to_string, this function gives locale-agnostic results
+/// and might also be faster.
+template <typename T, typename... Args>
+std::string ToChars(T value, Args&&... args) {
+  // According to various sources, the GNU libstdc++ and Microsoft's C++ STL
+  // allow up to 15 bytes of small string optimization, while clang's libc++
+  // goes up to 22 bytes. Choose the pessimistic value.
+  std::string out(15, 0);
+  auto res = std::to_chars(&out.front(), &out.back(), value, args...);
+  while (res.ec != std::errc{}) {
+    assert(res.ec == std::errc::value_too_large);
+    out.resize(out.capacity() * 2);
+    res = std::to_chars(&out.front(), &out.back(), value, args...);
+  }
+  const auto length = res.ptr - out.data();
+  assert(length <= static_cast<int64_t>(out.length()));
+  out[length] = 0;

Review Comment:
   I believe this is redundant: https://godbolt.org/z/6vcW1jEfh
   
   The call to resize *should* set `out[length]` to 0 so that `std::string` can fulfill its requirements for `c_str`.
   
   That being said, it should be harmless and I imagine would optimize out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1318983161

   https://issues.apache.org/jira/browse/ARROW-18350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1324882483

   @github-actions crossbow submit -g cpp


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1318983182

   :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1325189255

   I'm gonna merge now that CI is green.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1327015979

   Benchmark runs are scheduled for baseline = 62829c5ca81e5ddaef2a609745aae6e6d08d1e6b and contender = ad54d6ca3aed0e1022d1b135817d855659d482f9. ad54d6ca3aed0e1022d1b135817d855659d482f9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9fca032031554acaa83a7074ff797d90...dc029d79558d41c593b74e89f6d5919d/)
   [Finished :arrow_down:0.34% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fd8b1e6a73734b168b5596befc8dce74...880888c596fe427d9fee073324f8a29f/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/29f3675b32d046f5b7d33c541b31f1a5...6248b5ad692a4cc79e72caabf8d859fc/)
   [Finished :arrow_down:0.45% :arrow_up:0.07%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/658aa4ad6d934e13b551075be45152ff...bab608a7af064bbc932e7f6fa7f7e110/)
   Buildkite builds:
   [Finished] [`ad54d6ca` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1917)
   [Finished] [`ad54d6ca` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1939)
   [Finished] [`ad54d6ca` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1909)
   [Finished] [`ad54d6ca` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1931)
   [Finished] [`62829c5c` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1916)
   [Finished] [`62829c5c` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1938)
   [Finished] [`62829c5c` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1908)
   [Finished] [`62829c5c` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1930)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1325002712

   Revision: 32f378caf1cbd5931f6ac85f0e61ba03571c333f
   
   Submitted crossbow builds: [ursacomputing/crossbow @ ARROW-18350-to-chars-0](https://github.com/ursacomputing/crossbow/branches/all?query=ARROW-18350-to-chars-0)
   
   |Task|Status|
   |----|------|
   |test-alpine-linux-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-alpine-linux-cpp)](https://github.com/ursacomputing/crossbow//tree/ARROW-18350-to-chars-0-github-test-alpine-linux-cpp)|
   |test-build-cpp-fuzz|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-build-cpp-fuzz)](https://github.com/ursacomputing/crossbow//tree/ARROW-18350-to-chars-0-github-test-build-cpp-fuzz)|
   |test-conda-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-conda-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3532152257/jobs/5926155908)|
   |test-conda-cpp-valgrind|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=ARROW-18350-to-chars-0-azure-test-conda-cpp-valgrind)](https://github.com/ursacomputing/crossbow//tree/ARROW-18350-to-chars-0-azure-test-conda-cpp-valgrind)|
   |test-cuda-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-cuda-cpp)](https://github.com/ursacomputing/crossbow//tree/ARROW-18350-to-chars-0-github-test-cuda-cpp)|
   |test-debian-10-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-debian-10-cpp-amd64)](https://github.com/ursacomputing/crossbow//tree/ARROW-18350-to-chars-0-github-test-debian-10-cpp-amd64)|
   |test-debian-10-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow//tree/ARROW-18350-to-chars-0-github-test-debian-10-cpp-i386)|
   |test-debian-11-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-debian-11-cpp-amd64)](https://github.com/ursacomputing/crossbow//tree/ARROW-18350-to-chars-0-github-test-debian-11-cpp-amd64)|
   |test-debian-11-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-debian-11-cpp-i386)](https://github.com/ursacomputing/crossbow/actions/runs/3532150078/jobs/5926151930)|
   |test-fedora-35-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-fedora-35-cpp)](https://github.com/ursacomputing/crossbow//tree/ARROW-18350-to-chars-0-github-test-fedora-35-cpp)|
   |test-ubuntu-18.04-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-ubuntu-18.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3532151611/jobs/5926154911)|
   |test-ubuntu-18.04-cpp-release|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-ubuntu-18.04-cpp-release)](https://github.com/ursacomputing/crossbow/actions/runs/3532150490/jobs/5926152742)|
   |test-ubuntu-18.04-cpp-static|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-ubuntu-18.04-cpp-static)](https://github.com/ursacomputing/crossbow/actions/runs/3532153496/jobs/5926158543)|
   |test-ubuntu-20.04-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-ubuntu-20.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3532153227/jobs/5926157862)|
   |test-ubuntu-20.04-cpp-20|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-ubuntu-20.04-cpp-20)](https://github.com/ursacomputing/crossbow//tree/ARROW-18350-to-chars-0-github-test-ubuntu-20.04-cpp-20)|
   |test-ubuntu-20.04-cpp-bundled|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-ubuntu-20.04-cpp-bundled)](https://github.com/ursacomputing/crossbow/actions/runs/3532152720/jobs/5926156882)|
   |test-ubuntu-20.04-cpp-thread-sanitizer|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-ubuntu-20.04-cpp-thread-sanitizer)](https://github.com/ursacomputing/crossbow/actions/runs/3532151176/jobs/5926153907)|
   |test-ubuntu-22.04-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=ARROW-18350-to-chars-0-github-test-ubuntu-22.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3532149845/jobs/5926151295)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou merged pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou merged PR #14666:
URL: https://github.com/apache/arrow/pull/14666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1323827436

   > Are there any cases where `std::to_string` should be preferred you think?
   
   I don't think so (unless locale-dependence is desired).
   
   > Or, are most formatting functions that output to the user already going through some other kind of string formatting function?
   
   Places where performance is important generally use our home-grown formatting routines, yes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] westonpace commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
westonpace commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1324263672

   @pitrou maybe this ([gist](https://gist.github.com/westonpace/fa5f7fe400951d161ba181f5ee8a2fdb), [godbolt](https://godbolt.org/z/h8vsoh8oW))?  It's a mix of sfinae (the int version is preferred over the long version) and constexpr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on a diff in pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #14666:
URL: https://github.com/apache/arrow/pull/14666#discussion_r1030287857


##########
cpp/src/arrow/util/string.h:
##########
@@ -97,5 +100,31 @@ std::optional<std::string> Replace(std::string_view s, std::string_view token,
 ARROW_EXPORT
 arrow::Result<bool> ParseBoolean(std::string_view value);
 
+/// \brief An ergonomic wrapper around std::to_chars, returning a std::string
+///
+/// For most inputs, the std::string result will not incur any heap allocation
+/// thanks to small string optimization.
+///
+/// Compared to std::to_string, this function gives locale-agnostic results
+/// and might also be faster.
+template <typename T, typename... Args>
+std::string ToChars(T value, Args&&... args) {
+  // According to various sources, the GNU libstdc++ and Microsoft's C++ STL
+  // allow up to 15 bytes of small string optimization, while clang's libc++
+  // goes up to 22 bytes. Choose the pessimistic value.
+  std::string out(15, 0);
+  auto res = std::to_chars(&out.front(), &out.back(), value, args...);
+  while (res.ec != std::errc{}) {
+    assert(res.ec == std::errc::value_too_large);
+    out.resize(out.capacity() * 2);
+    res = std::to_chars(&out.front(), &out.back(), value, args...);
+  }
+  const auto length = res.ptr - out.data();
+  assert(length <= static_cast<int64_t>(out.length()));
+  out[length] = 0;

Review Comment:
   Hmm, you're right, we shouldn't need to do this on our own.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1324853062

   @westonpace Thanks a lot. I'm trying to come with a more condensed version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1324983549

   Revision: c165e592235510d97875a25251a17b9fb4ad8705
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-8fee9abfdd](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8fee9abfdd)
   
   |Task|Status|
   |----|------|
   |test-alpine-linux-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-alpine-linux-cpp)](https://github.com/ursacomputing/crossbow/tree/actions-8fee9abfdd-github-test-alpine-linux-cpp)|
   |test-build-cpp-fuzz|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-build-cpp-fuzz)](https://github.com/ursacomputing/crossbow/actions/runs/3532013922/jobs/5925848101)|
   |test-conda-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-conda-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3532007862/jobs/5925834842)|
   |test-conda-cpp-valgrind|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-8fee9abfdd-azure-test-conda-cpp-valgrind)](https://github.com/ursacomputing/crossbow/runs/9664733303)|
   |test-cuda-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-cuda-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3532008297/jobs/5925835612)|
   |test-debian-10-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-debian-10-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/3532015932/jobs/5925852554)|
   |test-debian-10-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow/actions/runs/3532015168/jobs/5925850636)|
   |test-debian-11-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-debian-11-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/3532009681/jobs/5925838735)|
   |test-debian-11-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-debian-11-cpp-i386)](https://github.com/ursacomputing/crossbow/actions/runs/3532008732/jobs/5925836527)|
   |test-fedora-35-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-fedora-35-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3532011209/jobs/5925842067)|
   |test-ubuntu-18.04-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-ubuntu-18.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3532016274/jobs/5925853268)|
   |test-ubuntu-18.04-cpp-release|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-ubuntu-18.04-cpp-release)](https://github.com/ursacomputing/crossbow/actions/runs/3532010255/jobs/5925839785)|
   |test-ubuntu-18.04-cpp-static|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-ubuntu-18.04-cpp-static)](https://github.com/ursacomputing/crossbow/actions/runs/3532014448/jobs/5925849263)|
   |test-ubuntu-20.04-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-ubuntu-20.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3532012374/jobs/5925844831)|
   |test-ubuntu-20.04-cpp-20|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-ubuntu-20.04-cpp-20)](https://github.com/ursacomputing/crossbow/actions/runs/3532010773/jobs/5925840871)|
   |test-ubuntu-20.04-cpp-bundled|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-ubuntu-20.04-cpp-bundled)](https://github.com/ursacomputing/crossbow/actions/runs/3532013445/jobs/5925846996)|
   |test-ubuntu-20.04-cpp-thread-sanitizer|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-ubuntu-20.04-cpp-thread-sanitizer)](https://github.com/ursacomputing/crossbow/actions/runs/3532012014/jobs/5925844059)|
   |test-ubuntu-22.04-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-8fee9abfdd-github-test-ubuntu-22.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3532012819/jobs/5925845721)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1326196574

   @wgtmac Sigh :-( As I understand it, you should be able to upgrade your Mac to a newer libc++ version (not sure how that's done, though)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1323828470

   @bkietz Can you think of a simple way to solve the incompleteness issue?
   
   > Darn, `std::to_chars` is not implemented for floating-point on all C++ standard libraries :-(
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1324979504

   @github-actions crossbow submit -g cpp


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1324887465

   Revision: 75f128ddc03496e4fcc26c5932cd28f2f774feda
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-4ecd6e6fc9](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4ecd6e6fc9)
   
   |Task|Status|
   |----|------|
   |test-alpine-linux-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-alpine-linux-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3531488437/jobs/5924717242)|
   |test-build-cpp-fuzz|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-build-cpp-fuzz)](https://github.com/ursacomputing/crossbow/actions/runs/3531487878/jobs/5924716212)|
   |test-conda-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-conda-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3531484463/jobs/5924708621)|
   |test-conda-cpp-valgrind|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-4ecd6e6fc9-azure-test-conda-cpp-valgrind)](https://github.com/ursacomputing/crossbow/runs/9663253578)|
   |test-cuda-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-cuda-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3531491370/jobs/5924723303)|
   |test-debian-10-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-debian-10-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/3531491028/jobs/5924722630)|
   |test-debian-10-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow/actions/runs/3531487507/jobs/5924715355)|
   |test-debian-11-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-debian-11-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/3531492105/jobs/5924724909)|
   |test-debian-11-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-debian-11-cpp-i386)](https://github.com/ursacomputing/crossbow/actions/runs/3531489184/jobs/5924718495)|
   |test-fedora-35-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-fedora-35-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3531486797/jobs/5924713632)|
   |test-ubuntu-18.04-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-ubuntu-18.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3531489701/jobs/5924719523)|
   |test-ubuntu-18.04-cpp-release|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-ubuntu-18.04-cpp-release)](https://github.com/ursacomputing/crossbow/actions/runs/3531490652/jobs/5924721601)|
   |test-ubuntu-18.04-cpp-static|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-ubuntu-18.04-cpp-static)](https://github.com/ursacomputing/crossbow/actions/runs/3531490208/jobs/5924720674)|
   |test-ubuntu-20.04-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-ubuntu-20.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3531492874/jobs/5924726344)|
   |test-ubuntu-20.04-cpp-20|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-ubuntu-20.04-cpp-20)](https://github.com/ursacomputing/crossbow/actions/runs/3531487128/jobs/5924714266)|
   |test-ubuntu-20.04-cpp-bundled|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-ubuntu-20.04-cpp-bundled)](https://github.com/ursacomputing/crossbow/actions/runs/3531486029/jobs/5924711668)|
   |test-ubuntu-20.04-cpp-thread-sanitizer|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-ubuntu-20.04-cpp-thread-sanitizer)](https://github.com/ursacomputing/crossbow/actions/runs/3531491682/jobs/5924724115)|
   |test-ubuntu-22.04-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-4ecd6e6fc9-github-test-ubuntu-22.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/3531486378/jobs/5924712514)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #14666: ARROW-18350: [C++] Use std::to_chars instead of std::to_string

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14666:
URL: https://github.com/apache/arrow/pull/14666#issuecomment-1324987400

   Wow, turns out `<charconv>` isn't even provided in some cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org