[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2001: IGNITE-18711 Leave logical topology gracefully when stopping Ignite node

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #2001:
URL: https://github.com/apache/ignite-3/pull/2001#discussion_r1182114552


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/compute/ItLogicalTopologyTest.java:
##########
@@ -337,6 +339,27 @@ public void onNodeValidated(LogicalNode validatedNode) {
         }
     }
 
+    @Test
+    void nodeLeavesLogicalTopologyOnStop() throws Exception {
+        IgniteImpl entryNode = node(0);
+
+        IgniteImpl secondIgnite = startNode(1);
+
+        entryNode.logicalTopologyService().addEventListener(listener);
+
+        stopNode(1);
+
+        assertTrue(waitForCondition(() -> !events.isEmpty(), TimeUnit.SECONDS.toMillis(10)), "Did not see any events in time");

Review Comment:
   Why do you need to use `waitForCondition` if you can simply `poll` the event queue in order to wait for an event to appear?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org