[GitHub] [incubator-kvrocks] PragmaTwice opened a new issue, #580: Proposal: Search library first before linking `libstdc++.a` in CMake

[GitBox <gi...@apache.org>]

PragmaTwice opened a new issue, #580:
URL: https://github.com/apache/incubator-kvrocks/issues/580

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   This idea is proposed by @git-hulk, and the following is the discussion at that time:
   > > > The problem is caused by that `-static-libstdc++` is added as a flag to the compiler in [CMakeLists.txt#L72](https://github.com/apache/incubator-kvrocks/blob/unstable/CMakeLists.txt#L72), which is not added in makefiles, so a static library of libstdc++ is needed.
   > > 
   > > 
   > > Maybe some tips should be added to README to let users know that kvrocks need libstdc++.a for build. @git-hulk
   > 
   > Yes, you are right. Do you think it's a good idea to search library first before linking?
   
   I think it is a good idea, there are two solutions for searching library:
   1. find library, and give an error or warning if not found; give an option to user of whether `-static-libstdc++` is enabled
   2. find library, do not enable `-static-libstdc++` if not found
   
   I prefer the first solution, because I think the second is more implicit, users may not know whether `-static-libstdc++` is enabled while they are building the project (it is totally depend on the environment).
   
   _Originally posted by @PragmaTwice in https://github.com/apache/incubator-kvrocks/issues/575#issuecomment-1125220948_
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk closed issue #580: Proposal: Search library first before linking `libstdc++.a` in CMake

[GitBox <gi...@apache.org>]

git-hulk closed issue #580: Proposal: Search library first before linking `libstdc++.a` in CMake
URL: https://github.com/apache/incubator-kvrocks/issues/580


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org