You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joerg Schad <jo...@gmail.com> on 2015/02/10 16:04:36 UTC

Re: Review Request 30827: Removed deprecated slave_id from ReregisterSlaveMessage.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30827/
-----------------------------------------------------------

(Updated Feb. 10, 2015, 3:04 p.m.)


Review request for mesos, Adam B, Ben Mahler, and Till Toenshoff.


Bugs: MESOS-1876
    https://issues.apache.org/jira/browse/MESOS-1876


Repository: mesos-incubating


Description
-------

see summary


Diffs
-----

  src/messages/messages.proto 44122bd 
  src/slave/slave.cpp fff2d72 

Diff: https://reviews.apache.org/r/30827/diff/


Testing
-------

make check


Thanks,

Joerg Schad


Re: Review Request 30827: Removed deprecated slave_id from ReregisterSlaveMessage.

Posted by Ben Mahler <be...@gmail.com>.

> On Feb. 10, 2015, 5:01 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [30827]
> > 
> > Failed command: ./support/apply-review.sh -n -r 30827
> > 
> > Error:
> >  2015-02-10 17:01:08 URL:https://reviews.apache.org/r/30827/diff/raw/ [1031/1031] -> "30827.patch" [1]
> > error: patch failed: src/slave/slave.cpp:975
> > error: src/slave/slave.cpp: patch does not apply
> > Failed to apply patch

Hi Joerg, could you please rebase this patch against master?


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30827/#review71801
-----------------------------------------------------------


On Feb. 10, 2015, 3:04 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30827/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 3:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1876
>     https://issues.apache.org/jira/browse/MESOS-1876
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.proto 44122bd 
>   src/slave/slave.cpp fff2d72 
> 
> Diff: https://reviews.apache.org/r/30827/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 30827: Removed deprecated slave_id from ReregisterSlaveMessage.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30827/#review71801
-----------------------------------------------------------


Bad patch!

Reviews applied: [30827]

Failed command: ./support/apply-review.sh -n -r 30827

Error:
 2015-02-10 17:01:08 URL:https://reviews.apache.org/r/30827/diff/raw/ [1031/1031] -> "30827.patch" [1]
error: patch failed: src/slave/slave.cpp:975
error: src/slave/slave.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Feb. 10, 2015, 3:04 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30827/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 3:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1876
>     https://issues.apache.org/jira/browse/MESOS-1876
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.proto 44122bd 
>   src/slave/slave.cpp fff2d72 
> 
> Diff: https://reviews.apache.org/r/30827/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 30827: Removed deprecated slave_id from ReregisterSlaveMessage.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30827/#review71951
-----------------------------------------------------------


Patch looks great!

Reviews applied: [30827]

All tests passed.

- Mesos ReviewBot


On Feb. 11, 2015, 10:19 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30827/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 10:19 a.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1876
>     https://issues.apache.org/jira/browse/MESOS-1876
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.proto 55b3a24ed05c04eaafc27243477bfc778a72b1d4 
>   src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635 
> 
> Diff: https://reviews.apache.org/r/30827/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 30827: Removed deprecated slave_id from ReregisterSlaveMessage.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30827/#review72078
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Feb. 11, 2015, 10:19 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30827/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 10:19 a.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1876
>     https://issues.apache.org/jira/browse/MESOS-1876
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.proto 55b3a24ed05c04eaafc27243477bfc778a72b1d4 
>   src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635 
> 
> Diff: https://reviews.apache.org/r/30827/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 30827: Removed deprecated slave_id from ReregisterSlaveMessage.

Posted by Joerg Schad <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30827/
-----------------------------------------------------------

(Updated Feb. 11, 2015, 10:19 a.m.)


Review request for mesos, Adam B, Ben Mahler, and Till Toenshoff.


Changes
-------

Rebased.


Bugs: MESOS-1876
    https://issues.apache.org/jira/browse/MESOS-1876


Repository: mesos-incubating


Description (updated)
-------

See summary.


Diffs (updated)
-----

  src/messages/messages.proto 55b3a24ed05c04eaafc27243477bfc778a72b1d4 
  src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635 

Diff: https://reviews.apache.org/r/30827/diff/


Testing
-------

make check


Thanks,

Joerg Schad


Re: Review Request 30827: Removed deprecated slave_id from ReregisterSlaveMessage.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30827/#review71791
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Feb. 10, 2015, 3:04 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30827/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 3:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1876
>     https://issues.apache.org/jira/browse/MESOS-1876
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.proto 44122bd 
>   src/slave/slave.cpp fff2d72 
> 
> Diff: https://reviews.apache.org/r/30827/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>