[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client

[GitBox <gi...@apache.org>]

Anonymitaet commented on a change in pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271#discussion_r768280413



##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,91 @@ fmt.Println(msg.Payload())
 canc()
 ```
 
+#### How to use Prometheus metrics in producer
+

Review comment:
       @imryao thanks for adding docs. 
   
   To allow users better understand the purpose of this part, can you add some explanations/context before the code example? For example, `what does the example do?`, `Are there any considerations that need to take into account when using Prometheus metrics in Go SDK?`, etc.

##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,91 @@ fmt.Println(msg.Payload())
 canc()
 ```
 
+#### How to use Prometheus metrics in producer

Review comment:
       @imryao +1 for separating code examples to each part (producer and consumer)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org