You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/12 09:52:47 UTC
[GitHub] [pulsar] liangyuanpeng opened a new pull request, #17077: Standalone Add param of --metadata-url for runing with metadata
liangyuanpeng opened a new pull request, #17077:
URL: https://github.com/apache/pulsar/pull/17077
### Motivation
Standalone support running with metadata, like etcd, And rocksdb still by default.
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: Yes, Standalone support running with metadata store, but rocksdb metadataStore by default.
### Documentation
Need to update docs?
- [] `doc-required`
- [x] `doc-not-needed`
- [ ] `doc`
- [ ] `doc-complete`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #17077:
URL: https://github.com/apache/pulsar/pull/17077#issuecomment-1219006355
>
Thanks for your reply, Yes, Standalone is more used to development and we can use other metadata to development for check the metadata after support running other metadata. Actually, i'm really do it, Base on etcd metadata store for write the dev code and not zookeeper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #17077:
URL: https://github.com/apache/pulsar/pull/17077#issuecomment-1213632510
@liangyuanpeng Any reason to support using separate metadata for standalone? The standalone is designed for development, not for production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17077:
URL: https://github.com/apache/pulsar/pull/17077#issuecomment-1257399758
Ping @codelipenghui, could you review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #17077:
URL: https://github.com/apache/pulsar/pull/17077#issuecomment-1237729099
@codelipenghui @tisonkun PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on a diff in pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on code in PR #17077:
URL: https://github.com/apache/pulsar/pull/17077#discussion_r948620701
##########
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java:
##########
@@ -434,10 +438,13 @@ public void close() {
}
}
-
- private void startBookieWithRocksDB() throws Exception {
- log.info("Starting BK with RocksDb metadata store");
- String metadataStoreUrl = "rocksdb://" + Paths.get(metadataDir).toAbsolutePath();
+ private void startBookieWithMetadataStore() throws Exception {
+ if(StringUtils.isBlank(metadataStoreUrl)){
+ log.info("Starting BK with RocksDb metadata store");
+ metadataStoreUrl = "rocksdb://" + Paths.get(metadataDir).toAbsolutePath();
+ }else{
+ log.info("Starting BK with metadata store:",metadataStoreUrl);
+ }
Review Comment:
Thanks for your review and i'm busy for otherthing, pick it up in the next week maybe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #17077:
URL: https://github.com/apache/pulsar/pull/17077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17077:
URL: https://github.com/apache/pulsar/pull/17077#discussion_r947514100
##########
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java:
##########
@@ -434,10 +438,13 @@ public void close() {
}
}
-
- private void startBookieWithRocksDB() throws Exception {
- log.info("Starting BK with RocksDb metadata store");
- String metadataStoreUrl = "rocksdb://" + Paths.get(metadataDir).toAbsolutePath();
+ private void startBookieWithMetadataStore() throws Exception {
+ if(StringUtils.isBlank(metadataStoreUrl)){
+ log.info("Starting BK with RocksDb metadata store");
+ metadataStoreUrl = "rocksdb://" + Paths.get(metadataDir).toAbsolutePath();
+ }else{
+ log.info("Starting BK with metadata store:",metadataStoreUrl);
+ }
Review Comment:
Please format this code block according to our code style settings. Briefly, add necessary blanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17077:
URL: https://github.com/apache/pulsar/pull/17077#issuecomment-1243406465
@liangyuanpeng Pulsar CI has been refactored a lot. You can merge the latest master to run CI tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #17077:
URL: https://github.com/apache/pulsar/pull/17077#issuecomment-1257198176
@codelipenghui PTAL,Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17077:
URL: https://github.com/apache/pulsar/pull/17077#issuecomment-1217518887
I think @liangyuanpeng wants to use other metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17077:
URL: https://github.com/apache/pulsar/pull/17077#discussion_r964554974
##########
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java:
##########
@@ -52,6 +52,7 @@
import org.apache.pulsar.packages.management.storage.filesystem.FileSystemPackagesStorageProvider;
import org.apache.pulsar.zookeeper.LocalBookkeeperEnsemble;
+
Review Comment:
Revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org