You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/05 06:54:04 UTC

[kudu-CR] [security] moved mini kdc into the test subdir 

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4965

Change subject: [security] moved mini_kdc into the test subdir
......................................................................

[security] moved mini_kdc into the test subdir

Moved mini_kdc code into the test sub-directory.
The idea of moving is inspired by Todd's comment on
  https://gerrit.cloudera.org/#/c/4926/

There are no functional changes in this patch.

Change-Id: I5f678f59e1911fd89191bd9b5dfb840e20d746a1
---
M src/kudu/integration-tests/external_mini_cluster-test.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/rpc/sasl_rpc-test.cc
M src/kudu/security/CMakeLists.txt
R src/kudu/security/test/mini_kdc-test.cc
R src/kudu/security/test/mini_kdc.cc
R src/kudu/security/test/mini_kdc.h
7 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/4965/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f678f59e1911fd89191bd9b5dfb840e20d746a1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [security] moved mini kdc into the test subdir

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.

Change subject: [security] moved mini_kdc into the test subdir
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f678f59e1911fd89191bd9b5dfb840e20d746a1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] [security] moved mini kdc into the test subdir

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged.

Change subject: [security] moved mini_kdc into the test subdir
......................................................................


[security] moved mini_kdc into the test subdir

Moved mini_kdc code into the test sub-directory.
The idea of moving is inspired by Todd's comment on
  https://gerrit.cloudera.org/#/c/4926/

There are no functional changes in this patch.

Change-Id: I5f678f59e1911fd89191bd9b5dfb840e20d746a1
Reviewed-on: http://gerrit.cloudera.org:8080/4965
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/integration-tests/external_mini_cluster-test.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/rpc/sasl_rpc-test.cc
M src/kudu/security/CMakeLists.txt
R src/kudu/security/test/mini_kdc-test.cc
R src/kudu/security/test/mini_kdc.cc
R src/kudu/security/test/mini_kdc.h
7 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Will Berkeley: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5f678f59e1911fd89191bd9b5dfb840e20d746a1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>