[jira] [Commented] (LOG4J2-2253) Reusable messages missing a garbage free parameter accessor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370507#comment-16370507 ] 

ASF GitHub Bot commented on LOG4J2-2253:
----------------------------------------

Github user cakofony commented on the issue:

    https://github.com/apache/logging-log4j2/pull/150
  
    another option here is to update #149 to hold `ThreadLocal<Object[]>` for 1-3 parameters where we can copy chunks of the parameters array rather than allocating a new one.
    
    That way we don't have to expand the API.
    
    Thoughts?


> Reusable messages missing a garbage free parameter accessor
> -----------------------------------------------------------
>
>                 Key: LOG4J2-2253
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2253
>             Project: Log4j 2
>          Issue Type: Improvement
>            Reporter: Carter Douglas Kozak
>            Priority: Major
>
> I have a layout which iterates through message parameters, however Message.getParameters causes allocation on many implementations.
> It appears that ReusableMessage.swapParameters is supposed to fill this gap, however some messages types do allocation when this is invoked (see ReusableParameterizedMessage) which isn't helpful for access on a single thread where we don't want to take ownership of values.
> I've put together a proposal for an accessor similar to MapMessage:
> https://github.com/apache/logging-log4j2/pull/150



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)