You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2017/08/01 20:49:12 UTC
svn commit: r1803707 - in
/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox:
cos/COSDocument.java pdfparser/PDFParser.java
Author: tilman
Date: Tue Aug 1 20:49:12 2017
New Revision: 1803707
URL: http://svn.apache.org/viewvc?rev=1803707&view=rev
Log:
PDFBOX-2852: remove unneeded nullcheck; improve javadoc; remove outdated javadoc comment
Modified:
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/PDFParser.java
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java?rev=1803707&r1=1803706&r2=1803707&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java Tue Aug 1 20:49:12 2017
@@ -359,9 +359,7 @@ public class COSDocument extends COSBase
/**
* This will get the document catalog.
*
- * Maybe this should move to an object at PDFEdit level
- *
- * @return catalog is the root of all document activities
+ * @return @return The catalog is the root of the document; never null.
*
* @throws IOException If no catalog can be found.
*/
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/PDFParser.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/PDFParser.java?rev=1803707&r1=1803706&r2=1803707&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/PDFParser.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/PDFParser.java Tue Aug 1 20:49:12 2017
@@ -236,7 +236,7 @@ public class PDFParser extends COSParser
root.setItem(COSName.TYPE, COSName.CATALOG);
}
COSObject catalogObj = document.getCatalog();
- if (catalogObj != null && catalogObj.getObject() instanceof COSDictionary)
+ if (catalogObj.getObject() instanceof COSDictionary)
{
parseDictObjects((COSDictionary) catalogObj.getObject(), (COSName[]) null);