You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2011/02/23 16:03:38 UTC
[jira] Created: (CASSANDRA-2227) add cache loading to row/key cache
tests
add cache loading to row/key cache tests
----------------------------------------
Key: CASSANDRA-2227
URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
Project: Cassandra
Issue Type: Test
Components: Core
Reporter: Jonathan Ellis
Assignee: Pavel Yaskevich
Priority: Minor
Fix For: 0.7.3
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2227) add cache loading to row/key
cache tests
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-2227:
---------------------------------------
Attachment: CASSANDRA-2227-v4-fix-rowCache-trunk.patch
> add cache loading to row/key cache tests
> ----------------------------------------
>
> Key: CASSANDRA-2227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-2227-v2.patch, CASSANDRA-2227-v3.patch, CASSANDRA-2227-v4-fix-rowCache-trunk.patch, CASSANDRA-2227.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2227) add cache loading to row/key
cache tests
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-2227:
-----------------------------------------
Attachment: CASSANDRA-2227-v3.patch
attached v3:
1) consolidates the insert and read (to populate cache) code
2) compares cached values against expected values instead of just checking if the key exists
3) exposes the cache from CFS directly instead of requiring a round about path through a reader to get a reference
other than the above changes, patch looks good
> add cache loading to row/key cache tests
> ----------------------------------------
>
> Key: CASSANDRA-2227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-2227-v2.patch, CASSANDRA-2227-v3.patch, CASSANDRA-2227.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2227) add cache loading to row/key
cache tests
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009821#comment-13009821 ]
Pavel Yaskevich commented on CASSANDRA-2227:
--------------------------------------------
np :)
> add cache loading to row/key cache tests
> ----------------------------------------
>
> Key: CASSANDRA-2227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-2227-v2.patch, CASSANDRA-2227-v3.patch, CASSANDRA-2227-v4-fix-rowCache-trunk.patch, CASSANDRA-2227.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2227) add cache loading to row/key
cache tests
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009976#comment-13009976 ]
Hudson commented on CASSANDRA-2227:
-----------------------------------
Integrated in Cassandra-0.7 #399 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/399/])
> add cache loading to row/key cache tests
> ----------------------------------------
>
> Key: CASSANDRA-2227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-2227-v2.patch, CASSANDRA-2227-v3.patch, CASSANDRA-2227-v4-fix-rowCache-trunk.patch, CASSANDRA-2227.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2227) add cache loading to row/key cache
tests
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-2227:
---------------------------------------
Attachment: CASSANDRA-2227.patch
> add cache loading to row/key cache tests
> ----------------------------------------
>
> Key: CASSANDRA-2227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: CASSANDRA-2227.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2227) add cache loading to row/key
cache tests
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009801#comment-13009801 ]
Jonathan Ellis commented on CASSANDRA-2227:
-------------------------------------------
I did my best to merge this to trunk but testRowCacheLoad is broken. I committed it anyway since the rest of the merge was a bunch of work thanks to counters -- can you check out current trunk and post a fix?
> add cache loading to row/key cache tests
> ----------------------------------------
>
> Key: CASSANDRA-2227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-2227-v2.patch, CASSANDRA-2227-v3.patch, CASSANDRA-2227.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2227) add cache loading to row/key
cache tests
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009474#comment-13009474 ]
Pavel Yaskevich commented on CASSANDRA-2227:
--------------------------------------------
+1, looks good to me, i just wanted to avoid changes in the main code base with my v2, thanks!
> add cache loading to row/key cache tests
> ----------------------------------------
>
> Key: CASSANDRA-2227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-2227-v2.patch, CASSANDRA-2227-v3.patch, CASSANDRA-2227.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2227) add cache loading to row/key
cache tests
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006643#comment-13006643 ]
Matthew F. Dennis commented on CASSANDRA-2227:
----------------------------------------------
don't use thread.sleep() waiting for the future to be done, just call future.get()
I wouldn't bother reading the cache directly from disk and checking the contents, but rather force a save (the way you do) and then force C* to completely load the cache as if it was opening the table for the first time and then checking the size/contents via the actual cache in use. The patch implements this at the end of the test anyway, so just assert there is nothing in the cache, then create the CFS and verify the cache size/contents. Do something similar for the row cache.
otherwise the patch looks good, but I would like to see these changes before it's committed.
> add cache loading to row/key cache tests
> ----------------------------------------
>
> Key: CASSANDRA-2227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-2227.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2227) add cache loading to row/key
cache tests
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-2227:
---------------------------------------
Attachment: CASSANDRA-2227-v2.patch
> add cache loading to row/key cache tests
> ----------------------------------------
>
> Key: CASSANDRA-2227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-2227-v2.patch, CASSANDRA-2227.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2227) add cache loading to row/key
cache tests
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009896#comment-13009896 ]
Jonathan Ellis commented on CASSANDRA-2227:
-------------------------------------------
committed, thanks!
> add cache loading to row/key cache tests
> ----------------------------------------
>
> Key: CASSANDRA-2227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-2227-v2.patch, CASSANDRA-2227-v3.patch, CASSANDRA-2227-v4-fix-rowCache-trunk.patch, CASSANDRA-2227.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2227) add cache loading to row/key cache
tests
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2227:
--------------------------------------
Remaining Estimate: 2h
Original Estimate: 2h
> add cache loading to row/key cache tests
> ----------------------------------------
>
> Key: CASSANDRA-2227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2227
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2227.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira