You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2014/07/17 08:35:36 UTC

[Bug 56735] New: [PATCH] Use custom temporary file directory in SXSSF

https://issues.apache.org/bugzilla/show_bug.cgi?id=56735

            Bug ID: 56735
           Summary: [PATCH] Use custom temporary file directory in SXSSF
           Product: POI
           Version: 3.11-dev
          Hardware: PC
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: SXSSF
          Assignee: dev@poi.apache.org
          Reporter: raul.wegmann@qrr.es

Created attachment 31825
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31825&action=edit
Patch that allows to optionally specify a custom temporary file directory in
SXSSF

The temporary files generated when using a SXSSFWorkbook are stored in the
default system temp directory. 

As our application is deployed together with other applications on the same
application server, we are not allowed to change the java.io.tmpdir system
property. Further, subclassing the SXSSFWorkbook and related classes is made
difficult because many methods are package protected.

Therefore we would like you to consider the inclusion of the attached patch,
which optionally allows to set a temp file directory property on the
SXSSFWorkbook. The API changes are backward compatible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 56735] [PATCH] Use custom temporary file directory in SXSSF

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56735

Nick Burch <ap...@gagravarr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Nick Burch <ap...@gagravarr.org> ---
We already have temp file helpers in POI, so it's a surprise to see that sxssf
isn't apparently using that - org.apache.poi.util.TempFile

I'd probably rather we get SXSSF following the rest of POI in using that, then
think about ways to allow you to override where that stores its files

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 56735] [PATCH] Use custom temporary file directory in SXSSF

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56735

Nick Burch <ap...@gagravarr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Nick Burch <ap...@gagravarr.org> ---
Thanks for this, patch applied in r1613246.

If you could review and close the GitHub pull request, that'd be great!

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 56735] [PATCH] Use custom temporary file directory in SXSSF

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56735

--- Comment #3 from Raúl Wegmann <ra...@qrr.es> ---
Please see the pull request at https://github.com/apache/poi/pull/10 for a set
of changes that would implement this feature using the
org.apache.poi.util.TempFile class and let me know what you think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 56735] [PATCH] Use custom temporary file directory in SXSSF

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56735

Raúl Wegmann <ra...@qrr.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |raul.wegmann@qrr.es

--- Comment #2 from Raúl Wegmann <ra...@qrr.es> ---
Thanks for pointing out the existing infrastructure. I will work on a new set
of patches for you to review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org