[GitHub] [druid] gianm commented on pull request #10786: move integration tests from ZooKeeper 3.4.x to 3.5.x

[GitBox <gi...@apache.org>]

gianm commented on pull request #10786:
URL: https://github.com/apache/druid/pull/10786#issuecomment-764848396


   I think it'd be good for now to test _both_ ZK 3.4 and 3.5 since we're meant to be in a migratory period where both servers are supported. Do you think you could add a smoke test that uses ZK 3.4? (I don't think we need to run every single test, but it'd be good to run some subset of the ITs.)
   
   > @clintropolis @gianm what's the process to build and update the base image?
   
   I think someone on the Imply team would need to push a new base image. That's probably the easiest way.
   
   We could also move the base image to the "apache" Docker account? We started using a base image from Imply in #5060 for performance reasons, and IIRC that pre-dates when Druid joined ASF, so using the ASF account wouldn't have been an option at the time. Maybe it is now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org