[GitHub] [druid] clintropolis commented on pull request #10949: Add support to first/last aggregators for numeric types during ingestion

[GitBox <gi...@apache.org>]

clintropolis commented on pull request #10949:
URL: https://github.com/apache/druid/pull/10949#issuecomment-796562253


   > One way I can come up with is to define some macros such as double_latest for different data types at the SQL layer.
   @gianm @clintropolis Do you have any other suggestions ?
   
   Hmm, so what I have had in mind to solve this is to be able to determine whether a `RowSignature` should be "finalized" or not in terms of the aggregator types. #9638 added some of the pieces needed for this (`getFinalizedType`, etc) and touches on this idea in the PR description, I just haven't yet got back this core refactoring work, or quite had time to fully think through how to determine when we need the 'finalized' signature or not.
   
   #10277 also added tracking of the "name" of the complex type on `ColumnCapabilities` (which typically is what populates the `RowSignature`) so that is potentially available to give greater detail than `ValueType.COMPLEX`, but I think the finalized type would be the useful information here.
   
   That said, I haven't had a look at this PR at all yet. I will try to get to it sometime soon, maybe I will have some ideas while looking over the code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org