[jira] [Closed] (AMQNET-465) SessionExecutor Stop() sets taskrunner to null and then tries to shut it down

["Timothy Bish (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQNET-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish closed AMQNET-465.
-------------------------------

    Resolution: Not A Problem

Look closer at the code and you see its calling stop on a local copy of the task runner.  

> SessionExecutor Stop() sets taskrunner to null and then tries to shut it down
> -----------------------------------------------------------------------------
>
>                 Key: AMQNET-465
>                 URL: https://issues.apache.org/jira/browse/AMQNET-465
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: NMS
>    Affects Versions: 1.6.2
>            Reporter: Matt Lagrotte
>            Assignee: Jim Gomes
>
> It appears that the Stop() method sets the taskRunner to null prior to Shutdown() which will cause a NullReferenceException which gets bubbled up and causes the stop to be incomplete.
> Here is the code:
> {code:title=SessionExecutor.cs|borderStyle=solid}
> public void Stop()
> {
>     if(messageQueue.Running)
>     {
>         messageQueue.Stop();
>         TaskRunner taskRunner = this.taskRunner;
>         if(taskRunner != null)
>         {
>             this.taskRunner = null;
>             taskRunner.Shutdown();
>         }
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)