You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/08 02:36:26 UTC

[GitHub] [flink] PatrickRen commented on a diff in pull request #20205: [FLINK-28250][Connector/Kafka] Fix exactly-once Kafka Sink out of memory

PatrickRen commented on code in PR #20205:
URL: https://github.com/apache/flink/pull/20205#discussion_r916412313


##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaCommitter.java:
##########
@@ -112,6 +112,8 @@ public void commit(Collection<CommitRequest<KafkaCommittable>> requests)
                         e);
                 recyclable.ifPresent(Recyclable::close);

Review Comment:
   What about removing this line as the `recyclable` will finally be closed anyway? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org