You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/20 08:17:26 UTC
[GitHub] [cloudstack] DaanHoogland opened a new issue #4488: add cpu percentage and value
DaanHoogland opened a new issue #4488:
URL: https://github.com/apache/cloudstack/issues/4488
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and master branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
cpu percentage and value as for memory #4478
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Improvement Request
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
API, metrics
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on master branch.
-->
~~~
all
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
##### SUMMARY
<!-- Explain the problem/feature briefly -->
as in #4478 (for memory), cpu could have percentage and value output for use in UI or scripts
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on issue #4488: add cpu percentage and value
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #4488:
URL: https://github.com/apache/cloudstack/issues/4488#issuecomment-731141822
@DaanHoogland This would mean reverting `cpuallocated` to the original allocated value and adding a new field `cpuallocatedwithoverprovisioning` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on issue #4488: add cpu percentage and value
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on issue #4488:
URL: https://github.com/apache/cloudstack/issues/4488#issuecomment-731141822
@DaanHoogland Would this mean reverting `cpuallocated` to the original allocated value and adding a new field `cpuallocatedwithoverprovisioning` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4488: add cpu percentage and value
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4488:
URL: https://github.com/apache/cloudstack/issues/4488#issuecomment-731205857
no, it would mean adding two new response parameters as done for memory and leaving the existing as is but deprecated. cc @weizhouapache @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #4488: add cpu percentage and value
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #4488:
URL: https://github.com/apache/cloudstack/issues/4488
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on issue #4488: add cpu percentage and value
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #4488:
URL: https://github.com/apache/cloudstack/issues/4488#issuecomment-731960707
@DaanHoogland It's always been a percentage, just that it was changed to consider overprovisioning in https://github.com/apache/cloudstack/commit/09de5e0b51d1cd0e1d84eef120ae48358300fdcd So would it make sense to revert it and add a new field `cpuallocatediwthoverprovisioning` for naming consistency ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4488: add cpu percentage and value
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4488:
URL: https://github.com/apache/cloudstack/issues/4488#issuecomment-731993671
so what would the resulting field(-names) be, @davidjumani ?
and which ones will in the endd be deprecated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4488: add cpu percentage and value
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4488:
URL: https://github.com/apache/cloudstack/issues/4488#issuecomment-791907252
Fixed in https://github.com/apache/cloudstack/pull/4499
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on issue #4488: add cpu percentage and value
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #4488:
URL: https://github.com/apache/cloudstack/issues/4488#issuecomment-732049025
I'd suggest reverting `cpuallocated` to not consider overcommit and introducing `cpuallocatediwthoverprovisioning` to follow the naming convention here
https://github.com/apache/cloudstack/blob/4.14/api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java#L106
https://github.com/apache/cloudstack/blob/4.14/api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java#L115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org